Update root name (#1934)

* Update root name * Update root name * update
getsentry · Mar 13, 2024 · e3d9076 · e3d9076
1 parent 3d30a22
commit e3d9076
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## Unreleased
 
-## Features
+### Features
 
 - Add TTFD (time to full display), which allows you to measure the time it takes to render the full screen ([#1920](https://github.com/getsentry/sentry-dart/pull/1920))
   - Requires using the [routing instrumentation](https://docs.sentry.io/platforms/flutter/integrations/routing-instrumentation/).
@@ -23,6 +23,11 @@
   - The `dio` integration and `SentryHttpClient` now take an additional `captureFailedRequests` option.
   - This is useful if you want to disable this option on native and only enable it on `dio` for example.
 
+### Improvements
+
+- Update root name for navigator observer ([#1934](https://github.com/getsentry/sentry-dart/pull/1934))
+  - The root name for transactions is now `root /` instead of `root ("/")`.
+
 ### Dependencies
 
 - Bump Android SDK from v7.5.0 to v7.6.0 ([#1927](https://github.com/getsentry/sentry-dart/pull/1927))

diff --git a/flutter/lib/src/navigation/sentry_navigator_observer.dart b/flutter/lib/src/navigation/sentry_navigator_observer.dart
@@ -224,7 +224,7 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
     }
 
     if (name == '/') {
-      name = 'root ("/")';
+      name = 'root /';
     }
     final transactionContext = SentryTransactionContext(
       name,

diff --git a/flutter/test/navigation/sentry_display_widget_test.dart b/flutter/test/navigation/sentry_display_widget_test.dart
@@ -81,7 +81,7 @@ void main() {
     expect(ttidSpan.context.operation,
         SentrySpanOperations.uiTimeToInitialDisplay);
     expect(ttidSpan.finished, isTrue);
-    expect(ttidSpan.context.description, 'root ("/") initial display');
+    expect(ttidSpan.context.description, 'root / initial display');
     expect(ttidSpan.origin, SentryTraceOrigins.autoUiTimeToDisplay);
 
     expect(ttidSpan.startTimestamp, appStartInfo.start);

diff --git a/flutter/test/sentry_navigator_observer_test.dart b/flutter/test/sentry_navigator_observer_test.dart
@@ -530,7 +530,7 @@ void main() {
         onFinish: anyNamed('onFinish'),
       )).captured.single as SentryTransactionContext;
 
-      expect(context.name, 'root ("/")');
+      expect(context.name, 'root /');
 
       hub.configureScope((scope) {
         expect(scope.span, span);