Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the Android and iOS plugin #1488

Closed
marandaneto opened this issue May 26, 2023 · 1 comment · Fixed by #1587
Closed

Add tests for the Android and iOS plugin #1488

marandaneto opened this issue May 26, 2023 · 1 comment · Fixed by #1587
Assignees
@denrase
Labels
Platform: Dart repository maintenance
Milestone
7.x

Comments

@marandaneto
Copy link
Contributor

marandaneto commented May 26, 2023 •
edited
Loading

Description

Avoid issues such as #1485

  • Make the code testable and add unit/and or integration tests for the Kotlin and Swift plugins.
  • Add CI step to run the tests
@marandaneto marandaneto mentioned this issue May 26, 2023
Merged
6 tasks
@marandaneto marandaneto added this to the 7.x milestone Jun 22, 2023
@marandaneto
Copy link
Contributor Author

Examples https://github.com/getsentry/sentry-react-native/blob/main/RNSentryTester/RNSentryTesterTests/RNSentry%2BinitNativeSdk.mm
https://github.com/getsentry/sentry-react-native/pull/3170/files also adding more tests on Android.
Use the HubAdapter whenever needed to avoid the Static class call which is harder to mock/fake.

@denrase denrase mentioned this issue Aug 7, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denrase denrase

Labels
Platform: Dart repository maintenance
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
7.x
Development

Successfully merging a pull request may close this issue.

Add tests for the Android and iOS plugin getsentry/sentry-dart
3 participants
@kahest @denrase @marandaneto