Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readTimeoutMillis wrongly configures connectionTimeoutMillis instead of the correct field #1485

Merged
merged 2 commits into from
May 26, 2023

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented May 25, 2023

Just realized this when reading code. Not tested locally, want to use CI to see whether this is a real bug (i.e. should fix) or not.

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.55 🎉

Comparison is base (86d4841) 90.18% compared to head (e05d3a6) 90.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
+ Coverage   90.18%   90.73%   +0.55%     
==========================================
  Files         181       61     -120     
  Lines        5776     2030    -3746     
==========================================
- Hits         5209     1842    -3367     
+ Misses        567      188     -379     

see 120 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fzyzcjy fzyzcjy marked this pull request as ready for review May 26, 2023 00:51
@fzyzcjy fzyzcjy changed the title Quick fix on wrong options Fix readTimeoutMillis wrongly configures connectionTimeoutMillis instead of the correct field May 26, 2023
@marandaneto
Copy link
Contributor

Good catch @fzyzcjy
Its time to address #1488

@marandaneto marandaneto enabled auto-merge (squash) May 26, 2023 07:45
@marandaneto marandaneto merged commit 2bae60c into getsentry:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants