Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement exception groups #1859

Open
1 of 2 tasks
krystofwoldrich opened this issue Feb 5, 2024 · 5 comments
Open
1 of 2 tasks

Implement exception groups #1859

krystofwoldrich opened this issue Feb 5, 2024 · 5 comments
Milestone

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Feb 5, 2024

Description

The Dart/Flutter SDK currently supports PlatformExceptions and ExceptionCause.

Related links

Notes

  • I'm not aware of how used or not the AggregateErrors are. After a quick search doesn't seem too common.
  • Implementing this might likely change grouping so it should be done in a major version.
  • Dart could add the parent-child relationship to the linked errors as described in the RFC.

Blocked by

@ueman
Copy link
Collaborator

ueman commented Feb 5, 2024

This is coming out of a package and it's not an error from Dart or Flutter. The package is also not particularly popular.

@krystofwoldrich krystofwoldrich changed the title Implement exception groups (AggregateError) Implement exception groups Feb 5, 2024
@krystofwoldrich
Copy link
Member Author

@ueman Thank you for the message, I've missed that, in that case, it doesn't make sense to add it to the SDK.

We could still add the parent-child relationship for the PlatformExceptions and Cause as described in the RFC.

@krystofwoldrich
Copy link
Member Author

After a closer look, it looks like the dart SDK is sending the native and dart exceptions in the opposite order than the specification says.

Dart send: Newer -> older. (Dart -> native) ->


Specs: Older -> newer. -> https://develop.sentry.dev/sdk/event-payloads/exception/

@marandaneto
Copy link
Contributor

After a closer look, it looks like the dart SDK is sending the native and dart exceptions in the opposite order than the specification says.

Dart send: Newer -> older. (Dart -> native) ->

Specs: Older -> newer. -> develop.sentry.dev/sdk/event-payloads/exception

Be sure before changing the order, I know that the BE reverses the list.

@krystofwoldrich
Copy link
Member Author

@marandaneto Thank you I will check that, don't want to break it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Blocked
Development

No branches or pull requests

4 participants