Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception aggregate mechanism #1866

Merged
merged 12 commits into from
Apr 18, 2024

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Feb 5, 2024

📜 Description

Adds the new field according to https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md#new-mechanism-fields

I didn't yet implement exception aggregates for anything. That can be done in follow-up PRs.
The current CI failures are due to targeting the v8 branch, I believe. At least, I can't see any failures related to the new code.

💡 Motivation and Context

https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md

A tiny step towards #1859

💚 How did you test it?

Updated tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Use it for PlatformException in the Flutter code.

#skip-changelog

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (fab52eb) to head (1cd7fbb).
Report is 245 commits behind head on release/8.0.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/8.0.0    #1866    +/-   ##
===============================================
  Coverage          88.55%   88.55%            
===============================================
  Files                205      218    +13     
  Lines               6884     7522   +638     
===============================================
+ Hits                6096     6661   +565     
- Misses               788      861    +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ueman ueman changed the title Exception aggregate Exception aggregate mechanism Feb 6, 2024
@buenaflor
Copy link
Contributor

some tests are still failing it looks like

@ueman ueman changed the base branch from release/8.0.0 to main February 8, 2024 10:21
@ueman ueman changed the base branch from main to release/8.0.0 February 8, 2024 10:22
@ueman
Copy link
Collaborator Author

ueman commented Feb 8, 2024

@buenaflor
I've fixed the issues. Is the target branch still the correct one, or should I target another branch?

@buenaflor
Copy link
Contributor

release/8.0.0 is fine, thx, I'll merge once everything is green (except sentry-dio, that's expected to fail currently fyi)

@ueman
Copy link
Collaborator Author

ueman commented Mar 5, 2024

@buenaflor Is there something I still need to do here? As far as I can tell, the remaining failing jobs aren't related to this PR.

@buenaflor
Copy link
Contributor

I'll merge main into v8 soon and the ci should be green then

@buenaflor buenaflor merged commit 9acd049 into getsentry:release/8.0.0 Apr 18, 2024
107 of 114 checks passed
@ueman ueman deleted the exception-aggregates branch April 18, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants