Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the purpose of sentryClientName #584

Closed
M123-dev opened this issue Sep 10, 2021 · 2 comments
Closed

What is the purpose of sentryClientName #584

M123-dev opened this issue Sep 10, 2021 · 2 comments
Assignees
@denrase
Labels
enhancement Platform: Dart
Milestone
7.0.0

Comments

@M123-dev
Copy link
Contributor

I just came across the sentryClientName in the SentryOptions and while looking at the implementation I noticed that this value is not used anywhere in this package. Did I miss something or can the field be removed / deprecated?
@marandaneto
Copy link
Contributor

indeed, the SDK is using options.sdk.identifier instead of options.sentryClientName, I'd say options.sdk.identifier can be removed in favor of options.sentryClientName, and sentryClientName is used as User-Agent when making API requests to Sentry

@M123-dev M123-dev mentioned this issue Sep 11, 2021
Merged
@marandaneto marandaneto added this to the 7.0.0 milestone Mar 24, 2022
@denrase denrase mentioned this issue Nov 15, 2022
Closed
5 tasks
@marandaneto
Copy link
Contributor

This should be on top of the v7.0.0 branch

@denrase denrase mentioned this issue Nov 15, 2022
Merged
5 tasks
marandaneto pushed a commit that referenced this issue Nov 15, 2022
@denrase
Use sentryClientName instead of sdk.identifier (#1135)
995bec7 
Closes #584
AP2Topper0127 added a commit to AP2Topper0127/dart_sentry that referenced this issue Aug 1, 2024
@AP2Topper0127
Use sentryClientName instead of sdk.identifier (#1135)
00e4866 
Closes getsentry/sentry-dart#584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denrase denrase

Labels
enhancement Platform: Dart
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Use sentryClientName instead of sdk.identifier getsentry/sentry-dart
5 participants
@ueman @philipphofmann @denrase @marandaneto @M123-dev