Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align span spec for serialize ops #1024

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Align span spec for serialize ops #1024

merged 2 commits into from
Sep 28, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Sep 28, 2022 •
edited
Loading

📜 Description

💡 Motivation and Context

Closes #1022

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

brustolin
brustolin approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 4082348 into main Sep 28, 2022
@marandaneto marandaneto deleted the chore/align-span-op branch September 28, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brustolin brustolin brustolin approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align serialize span ops
2 participants
@marandaneto @brustolin