Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle traces sampler exception #1040

Merged
merged 5 commits into from
Oct 4, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Oct 3, 2022

📜 Description

Closes #1025

💡 Motivation and Context

  • Capture and log exception in options' traces sampler.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

CHANGELOG.md Outdated Show resolved Hide resolved
@denrase denrase changed the title Enha: Handle traces sampler exception Fix: Handle traces sampler exception Oct 3, 2022
@denrase denrase marked this pull request as ready for review October 3, 2022 13:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 90.48% // Head: 91.37% // Increases project coverage by +0.88% 🎉

Coverage data is based on head (b9bd35c) compared to base (b016e63).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
+ Coverage   90.48%   91.37%   +0.88%     
==========================================
  Files         114        9     -105     
  Lines        3572      197    -3375     
==========================================
- Hits         3232      180    -3052     
+ Misses        340       17     -323     
Impacted Files Coverage Δ
dart/lib/src/sentry_traces_sampler.dart
dart/lib/src/http_client/breadcrumb_client.dart
dart/lib/src/protocol/breadcrumb.dart
dart/lib/src/transport/rate_limiter.dart
dart/lib/src/sentry_user_feedback.dart
dart/lib/src/utils.dart
dart/lib/src/protocol/span_status.dart
dart/lib/src/transport/http_transport.dart
dart/lib/src/sentry_options.dart
dart/lib/src/sentry_span_interface.dart
... and 95 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto merged commit b40e31f into main Oct 4, 2022
@marandaneto marandaneto deleted the enha/handle-traces-sampler-exception branch October 4, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture Callback Exceptions for traces sampler
3 participants