Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SentryDevice cast error #1059

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Oct 10, 2022

📜 Description

Fixes an issue wehre SentryDevice could not be parsed.

💡 Motivation and Context

The double values screen_height_pixels and screen_width_pixels could not be parsed, wich lead to a failing loadContextsIntegration.

This was observed on an iPhone 14 Pro Simulator on iOS 16:

Bildschirmfoto 2022-10-10 um 11 19 42

💚 How did you test it?

Added unit test.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

I did not trace why we unexpectedly have double values here. This might have to do with a behaviour change of either the iOS SDK or with iOS 16.

@denrase denrase marked this pull request as ready for review October 10, 2022 09:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Base: 91.37% // Head: 91.37% // No change to project coverage 👍

Coverage data is based on head (389ff74) compared to base (3fc395e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files           9        9           
  Lines         197      197           
=======================================
  Hits          180      180           
  Misses         17       17           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@marandaneto marandaneto merged commit fb57416 into main Oct 10, 2022
@marandaneto marandaneto deleted the fix/sentry-device-cast-errors branch October 10, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants