Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dependency conflict with package_info_plus v2 #1068

Merged
merged 6 commits into from
Oct 11, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 11, 2022

📜 Description

Avoid dependency conflict with package_info_plus v2

💡 Motivation and Context

Closes #1066

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 334.38 ms 366.00 ms 31.62 ms
Size 5.94 MiB 6.92 MiB 1001.71 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6d317ea 303.46 ms 356.06 ms 52.60 ms
633cf2e 289.36 ms 340.38 ms 51.02 ms
9c5aec6 287.33 ms 320.94 ms 33.61 ms
49a149b 301.96 ms 344.51 ms 42.55 ms
af2d175 279.08 ms 312.37 ms 33.29 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms

App size

Revision Plain With Sentry Diff
6d317ea 5.94 MiB 6.92 MiB 1001.74 KiB
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB
49a149b 5.94 MiB 6.92 MiB 1001.54 KiB
af2d175 5.94 MiB 6.92 MiB 1001.83 KiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB

Previous results on branch: fix/package_info_plus-version

Startup times

Revision Plain With Sentry Diff
3fc87e6 325.59 ms 383.20 ms 57.61 ms
fcf5e86 277.90 ms 311.29 ms 33.39 ms

App size

Revision Plain With Sentry Diff
3fc87e6 5.94 MiB 6.92 MiB 1001.51 KiB
fcf5e86 5.94 MiB 6.92 MiB 1001.51 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1277.50 ms 1293.77 ms 16.27 ms
Size 8.15 MiB 9.12 MiB 987.35 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
49a149b 1296.47 ms 1320.20 ms 23.73 ms
633cf2e 1257.96 ms 1275.73 ms 17.77 ms
3e5ee37 1248.25 ms 1265.38 ms 17.13 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
9c5aec6 1266.51 ms 1274.65 ms 8.14 ms
1c6eb5b 1277.85 ms 1285.71 ms 7.86 ms
6d317ea 1277.27 ms 1287.47 ms 10.20 ms

App size

Revision Plain With Sentry Diff
49a149b 8.15 MiB 9.12 MiB 986.26 KiB
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB
3e5ee37 8.15 MiB 9.12 MiB 986.23 KiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
9c5aec6 8.15 MiB 9.12 MiB 986.23 KiB
1c6eb5b 8.15 MiB 9.12 MiB 986.27 KiB
6d317ea 8.15 MiB 9.12 MiB 986.26 KiB

Previous results on branch: fix/package_info_plus-version

Startup times

Revision Plain With Sentry Diff
0211da1 1276.02 ms 1310.10 ms 34.08 ms
fcf5e86 1255.00 ms 1274.31 ms 19.31 ms
3fc87e6 1261.96 ms 1282.80 ms 20.84 ms

App size

Revision Plain With Sentry Diff
0211da1 8.15 MiB 9.12 MiB 987.35 KiB
fcf5e86 8.15 MiB 9.12 MiB 987.38 KiB
3fc87e6 8.15 MiB 9.12 MiB 987.35 KiB

@marandaneto marandaneto enabled auto-merge (squash) October 11, 2022 13:58
@marandaneto marandaneto merged commit 56810ff into main Oct 11, 2022
@marandaneto marandaneto deleted the fix/package_info_plus-version branch October 11, 2022 14:19
@marandaneto marandaneto mentioned this pull request Oct 12, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants