Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package_info_plus #1084

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Update package_info_plus #1084

merged 3 commits into from
Oct 19, 2022

Conversation

ThexXTURBOXx
Copy link
Contributor

📜 Description

This PR allows package_info_plus to be used in its newest version 3.0.0.

💡 Motivation and Context

The federated two-package refactor can now be used together with sentry_flutter.

💚 How did you test it?

All the workflows went through and the Sentry functionality in my app still works perfectly fine with the new version.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@marandaneto
Copy link
Contributor

@ThexXTURBOXx thanks.
Please add an entry to the changelog, similar to https://github.com/getsentry/sentry-dart/blob/main/CHANGELOG.md#fixes-1

@ThexXTURBOXx
Copy link
Contributor Author

@marandaneto Done! :)

@marandaneto marandaneto enabled auto-merge (squash) October 19, 2022 06:46
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 89.90% // Head: 91.37% // Increases project coverage by +1.46% 🎉

Coverage data is based on head (248e930) compared to base (870f5eb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   89.90%   91.37%   +1.46%     
==========================================
  Files         106        9      -97     
  Lines        3388      197    -3191     
==========================================
- Hits         3046      180    -2866     
+ Misses        342       17     -325     
Impacted Files Coverage Δ
dart/lib/src/sentry_trace_context_header.dart
...art/lib/src/http_client/failed_request_client.dart
...art/lib/src/environment/environment_variables.dart
dart/lib/src/http_client/tracing_client.dart
dart/lib/src/protocol/sentry_transaction_info.dart
dart/lib/src/sentry_envelope.dart
dart/lib/src/protocol/sdk_info.dart
dart/lib/src/transport/noop_transport.dart
dart/lib/src/utils/_io_get_isolate_name.dart
dart/lib/src/transport/rate_limit_parser.dart
... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto merged commit ef2f368 into getsentry:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants