Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kotlin version for examples #1091

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Fix kotlin version for examples #1091

merged 1 commit into from
Oct 25, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 25, 2022

📜 Description

#skip-changelog

💡 Motivation and Context

packageinfo requires a newer version since they have bumped their kotlin version.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 89.98% // Head: 89.98% // No change to project coverage 👍

Coverage data is based on head (533ce65) compared to base (eecbbca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1091   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files         115      115           
  Lines        3585     3585           
=======================================
  Hits         3226     3226           
  Misses        359      359           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 317.35 ms 365.53 ms 48.18 ms
Size 5.94 MiB 6.92 MiB 1005.98 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
eb1a7c1 332.98 ms 381.55 ms 48.57 ms
72dfc83 298.62 ms 340.14 ms 41.52 ms
9c5aec6 287.33 ms 320.94 ms 33.61 ms
870f5eb 329.45 ms 369.29 ms 39.84 ms
322aa66 284.98 ms 341.76 ms 56.78 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
21845e2 345.08 ms 382.82 ms 37.74 ms
49a149b 301.96 ms 344.51 ms 42.55 ms
633cf2e 289.36 ms 340.38 ms 51.02 ms
559d28f 302.35 ms 339.53 ms 37.18 ms

App size

Revision Plain With Sentry Diff
eb1a7c1 5.94 MiB 6.92 MiB 1005.76 KiB
72dfc83 5.94 MiB 6.92 MiB 1001.71 KiB
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB
870f5eb 5.94 MiB 6.92 MiB 1005.77 KiB
322aa66 5.94 MiB 6.92 MiB 1005.75 KiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
21845e2 5.94 MiB 6.92 MiB 1003.77 KiB
49a149b 5.94 MiB 6.92 MiB 1001.54 KiB
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1254.80 ms 1276.80 ms 22.00 ms
Size 8.15 MiB 9.13 MiB 1000.46 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
21845e2 1279.37 ms 1298.81 ms 19.45 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
6d317ea 1277.27 ms 1287.47 ms 10.20 ms
1c6eb5b 1277.85 ms 1285.71 ms 7.86 ms
322aa66 1251.68 ms 1275.52 ms 23.84 ms
9c5aec6 1266.51 ms 1274.65 ms 8.14 ms
56810ff 1267.59 ms 1293.48 ms 25.89 ms
eecbbca 1264.90 ms 1286.33 ms 21.43 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
3e5ee37 1248.25 ms 1265.38 ms 17.13 ms

App size

Revision Plain With Sentry Diff
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
6d317ea 8.15 MiB 9.12 MiB 986.26 KiB
1c6eb5b 8.15 MiB 9.12 MiB 986.27 KiB
322aa66 8.15 MiB 9.12 MiB 992.53 KiB
9c5aec6 8.15 MiB 9.12 MiB 986.23 KiB
56810ff 8.15 MiB 9.12 MiB 987.35 KiB
eecbbca 8.15 MiB 9.10 MiB 965.26 KiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
3e5ee37 8.15 MiB 9.12 MiB 986.23 KiB

@marandaneto marandaneto merged commit 613760b into main Oct 25, 2022
@marandaneto marandaneto deleted the fix/kotlin-examples branch October 25, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants