Add fragment to HTTP Client errors and fix user sync #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.08% // Head: 90.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
+ Coverage 90.08% 90.09% +0.01%
==========================================
Files 107 107
Lines 3388 3393 +5
==========================================
+ Hits 3052 3057 +5
Misses 336 336
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d7758e8 | 300.12 ms | 349.88 ms | 49.76 ms |
| 4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
| ef2f368 | 350.06 ms | 429.44 ms | 79.38 ms |
| 3e9fb0e | 329.14 ms | 359.16 ms | 30.02 ms |
| f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
| 0ceb89c | 304.57 ms | 357.18 ms | 52.61 ms |
| 3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
| 56810ff | 309.72 ms | 352.26 ms | 42.54 ms |
| 559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
| 633cf2e | 289.36 ms | 340.38 ms | 51.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d7758e8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
| ef2f368 | 5.94 MiB | 6.89 MiB | 975.81 KiB |
| 3e9fb0e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 0ceb89c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
| 56810ff | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
| 559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
| 633cf2e | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
marandaneto
changed the title
|
@brustolin @krystofwoldrich would love a review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add fragments to HTTP Client errors
Fix user sync
💡 Motivation and Context
Mixed up 3 PRs together
#1057, #1054 and #1065
💚 How did you test it?
📝 Checklist
🔮 Next steps