-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism to Dio Http Client error #1114
Conversation
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7758e8 | 300.12 ms | 349.88 ms | 49.76 ms |
4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
ef2f368 | 350.06 ms | 429.44 ms | 79.38 ms |
3e9fb0e | 329.14 ms | 359.16 ms | 30.02 ms |
f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
0ceb89c | 304.57 ms | 357.18 ms | 52.61 ms |
3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
56810ff | 309.72 ms | 352.26 ms | 42.54 ms |
559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
633cf2e | 289.36 ms | 340.38 ms | 51.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7758e8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
ef2f368 | 5.94 MiB | 6.89 MiB | 975.81 KiB |
3e9fb0e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
0ceb89c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
56810ff | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
633cf2e | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
Codecov ReportBase: 90.09% // Head: 90.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
==========================================
+ Coverage 90.09% 90.18% +0.09%
==========================================
Files 107 116 +9
Lines 3393 3588 +195
==========================================
+ Hits 3057 3236 +179
- Misses 336 352 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7758e8 | 1271.69 ms | 1288.08 ms | 16.39 ms |
1c6eb5b | 1277.85 ms | 1285.71 ms | 7.86 ms |
72dfc83 | 1262.50 ms | 1289.75 ms | 27.25 ms |
9c5aec6 | 1266.51 ms | 1274.65 ms | 8.14 ms |
5603ab2 | 1268.47 ms | 1280.73 ms | 12.26 ms |
6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
eb1a7c1 | 1281.25 ms | 1295.40 ms | 14.15 ms |
4efee31 | 1270.33 ms | 1285.75 ms | 15.42 ms |
559d28f | 1265.04 ms | 1288.96 ms | 23.92 ms |
0ceb89c | 1252.02 ms | 1271.78 ms | 19.75 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7758e8 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
1c6eb5b | 8.15 MiB | 9.12 MiB | 986.27 KiB |
72dfc83 | 8.15 MiB | 9.12 MiB | 987.30 KiB |
9c5aec6 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
5603ab2 | 8.15 MiB | 9.12 MiB | 990.57 KiB |
6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
eb1a7c1 | 8.15 MiB | 9.13 MiB | 1000.10 KiB |
4efee31 | 8.15 MiB | 9.12 MiB | 991.35 KiB |
559d28f | 8.15 MiB | 9.12 MiB | 987.32 KiB |
0ceb89c | 8.15 MiB | 9.12 MiB | 989.78 KiB |
📜 Description
💡 Motivation and Context
Align spec for HTTP Client errors https://develop.sentry.dev/sdk/features/#http-client-errors
Dio events now are possible to be searchable via mechanism.
💚 How did you test it?
📝 Checklist
🔮 Next steps