-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not attach headers if Span is NoOp #1143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
eb1a7c1 | 332.98 ms | 381.55 ms | 48.57 ms |
613760b | 373.42 ms | 399.33 ms | 25.92 ms |
0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
379d7a8 | 327.10 ms | 355.39 ms | 28.29 ms |
3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
870f5eb | 329.45 ms | 369.29 ms | 39.84 ms |
abcdba3 | 354.68 ms | 399.04 ms | 44.36 ms |
9c5aec6 | 287.33 ms | 320.94 ms | 33.61 ms |
21845e2 | 345.08 ms | 382.82 ms | 37.74 ms |
453e1bc | 320.41 ms | 372.73 ms | 52.32 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
eb1a7c1 | 5.94 MiB | 6.92 MiB | 1005.76 KiB |
613760b | 5.94 MiB | 6.92 MiB | 1005.98 KiB |
0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
379d7a8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
870f5eb | 5.94 MiB | 6.92 MiB | 1005.77 KiB |
abcdba3 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
9c5aec6 | 5.94 MiB | 6.92 MiB | 1001.61 KiB |
21845e2 | 5.94 MiB | 6.92 MiB | 1003.77 KiB |
453e1bc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
Codecov ReportBase: 91.39% // Head: 91.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
+ Coverage 91.39% 91.44% +0.04%
==========================================
Files 9 9
Lines 186 187 +1
==========================================
+ Hits 170 171 +1
Misses 16 16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📜 Description
Do not attach headers if Span is NoOp
💡 Motivation and Context
getsentry/sentry-java#2376
💚 How did you test it?
📝 Checklist
🔮 Next steps