Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableUserInteractionTracing sometimes finds the wrong widget #1212

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 4, 2023

📜 Description

💡 Motivation and Context

Fix #1208

💚 How did you test it?

Running the given example in the issue.
The WidgetTester finds the right widget but testing behaves differently due to custom HitTestBehavior most likely.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 328.76 ms 375.40 ms 46.64 ms
Size 5.94 MiB 6.96 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ccc09e4 308.21 ms 357.74 ms 49.54 ms
aed5947 295.70 ms 348.18 ms 52.48 ms
fbf42af 323.04 ms 365.09 ms 42.04 ms
cdf7172 348.54 ms 390.81 ms 42.27 ms
2f8f173 323.31 ms 373.29 ms 49.97 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
559d28f 302.35 ms 339.53 ms 37.18 ms
72dfc83 298.62 ms 340.14 ms 41.52 ms
ae02632 309.16 ms 348.98 ms 39.82 ms
eb1a7c1 332.98 ms 381.55 ms 48.57 ms

App size

Revision Plain With Sentry Diff
ccc09e4 5.94 MiB 6.95 MiB 1.01 MiB
aed5947 5.94 MiB 6.96 MiB 1.02 MiB
fbf42af 5.94 MiB 6.96 MiB 1.02 MiB
cdf7172 5.94 MiB 6.95 MiB 1.01 MiB
2f8f173 5.94 MiB 6.95 MiB 1.01 MiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
72dfc83 5.94 MiB 6.92 MiB 1001.71 KiB
ae02632 5.94 MiB 6.95 MiB 1.01 MiB
eb1a7c1 5.94 MiB 6.92 MiB 1005.76 KiB

Previous results on branch: fix/ui_misclick

Startup times

Revision Plain With Sentry Diff
20c9340 310.32 ms 365.96 ms 55.64 ms
0080784 341.89 ms 391.42 ms 49.53 ms

App size

Revision Plain With Sentry Diff
20c9340 5.94 MiB 6.96 MiB 1.02 MiB
0080784 5.94 MiB 6.96 MiB 1.02 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1257.84 ms 1270.12 ms 12.29 ms
Size 8.16 MiB 9.17 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3f23617 1261.93 ms 1286.10 ms 24.17 ms
1131914 1277.20 ms 1300.20 ms 23.00 ms
6325c3b 1266.52 ms 1291.06 ms 24.54 ms
613760b 1263.10 ms 1277.27 ms 14.16 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
eecbbca 1264.90 ms 1286.33 ms 21.43 ms
691aa3b 1265.57 ms 1282.13 ms 16.55 ms
0ceb89c 1252.02 ms 1271.78 ms 19.75 ms
62dde43 1258.43 ms 1276.81 ms 18.38 ms
a609134 1254.50 ms 1265.08 ms 10.58 ms

App size

Revision Plain With Sentry Diff
3f23617 8.16 MiB 9.17 MiB 1.01 MiB
1131914 8.16 MiB 9.17 MiB 1.01 MiB
6325c3b 8.16 MiB 9.17 MiB 1.01 MiB
613760b 8.15 MiB 9.13 MiB 1000.46 KiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
eecbbca 8.15 MiB 9.10 MiB 965.26 KiB
691aa3b 8.16 MiB 9.17 MiB 1.01 MiB
0ceb89c 8.15 MiB 9.12 MiB 989.78 KiB
62dde43 8.16 MiB 9.17 MiB 1.01 MiB
a609134 8.16 MiB 9.16 MiB 1.01 MiB

Previous results on branch: fix/ui_misclick

Startup times

Revision Plain With Sentry Diff
0080784 1253.92 ms 1279.54 ms 25.62 ms

App size

Revision Plain With Sentry Diff
0080784 8.16 MiB 9.17 MiB 1.01 MiB

@marandaneto marandaneto marked this pull request as ready for review January 9, 2023 11:30
@codecov-commenter
Copy link

Codecov Report

Base: 88.87% // Head: 88.87% // No change to project coverage 👍

Coverage data is based on head (20c9340) compared to base (9928a74).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1212   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files         121      121           
  Lines        3810     3810           
=======================================
  Hits         3386     3386           
  Misses        424      424           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the changelog, it LGTM.

Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto enabled auto-merge (squash) January 9, 2023 13:31
@marandaneto marandaneto merged commit 8d64376 into main Jan 9, 2023
@marandaneto marandaneto deleted the fix/ui_misclick branch January 9, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentryUserInteractionWidget sometimes finds the wrong widget
4 participants