Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable APM features by default #1217

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Conversation

marandaneto
Copy link
Contributor

📜 Description

💡 Motivation and Context

Closes #1173

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

CHANGELOG.md Outdated
@@ -28,6 +28,10 @@
- Use `sentryClientName` instead of `sdk.identifier` ([#1135](https://github.com/getsentry/sentry-dart/pull/1135))
- Refactor `BindingUtils` to `BindingWrapper` to enable the use of custom bindings ([#1184](https://github.com/getsentry/sentry-dart/pull/1184))
- Bump Flutter min to 3.0.0 and Dart to 2.17.0 ([#1180](https://github.com/getsentry/sentry-dart/pull/1180))
- Enable APM features by default ([#1217](https://github.com/getsentry/sentry-dart/pull/1217))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 7.0.0.
    Consider moving the entry to the ## Unreleased section, please.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v7.0.0@20def04). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             v7.0.0    #1217   +/-   ##
=========================================
  Coverage          ?   88.02%           
=========================================
  Files             ?      120           
  Lines             ?     3784           
  Branches          ?        0           
=========================================
  Hits              ?     3331           
  Misses            ?      453           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CHANGELOG is wrong, but other than that LGTM.

@marandaneto
Copy link
Contributor Author

Looks like CHANGELOG is wrong, but other than that LGTM.

Good catch, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants