Fix binding wrapper export #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueman
requested review from
marandaneto,
brustolin and
krystofwoldrich
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1234 +/- ##
=========================================
Coverage ? 88.73%
=========================================
Files ? 122
Lines ? 3818
Branches ? 0
=========================================
Hits ? 3388
Misses ? 430
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@ueman can you add a changelog entry since its a fix? thanks. |
ueman
commented
Jan 23, 2023
| @@ -11,6 +11,7 @@ | |||
| - Remove deprecated field from the `SentryFlutterOptions` class. | |||
| - `anrTimeoutIntervalMillis`, using the `anrTimeoutInterval` instead. | |||
| - `autoSessionTrackingIntervalMillis`, using the `autoSessionTrackingInterval` instead. | |||
| - Fix export for `BindingWrapper` ([#1234](https://github.com/getsentry/sentry-dart/pull/1234)) | |||
There was a problem hiding this comment.
I just noticed that this PR has the number 1234 😄
marandaneto
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The binding wrapper wasn't correctly exported, and it was also marked as internal. It should have been marked as
experimental💡 Motivation and Context
This allows the binding wrapper to be used in the consumers code.
💚 How did you test it?
📝 Checklist
🔮 Next steps