Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass processed Breadcrumb to scope observer #1298

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 28, 2023

📜 Description

  • Pass processed breadcrumbs to scope oberver.

💡 Motivation and Context

Closes #1296

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@denrase denrase marked this pull request as ready for review February 28, 2023 14:51
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.46 🎉

Comparison is base (d2f62d6) 89.36% compared to head (74426f1) 89.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
+ Coverage   89.36%   89.82%   +0.46%     
==========================================
  Files          45      155     +110     
  Lines        1580     5063    +3483     
==========================================
+ Hits         1412     4548    +3136     
- Misses        168      515     +347     
Impacted Files Coverage Δ
dart/lib/src/scope.dart 96.72% <100.00%> (ø)
dart/lib/src/integration.dart 100.00% <0.00%> (ø)
...rt/lib/src/sentry_client_attachment_processor.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/span_status.dart 96.49% <0.00%> (ø)
...ib/src/sentry_attachment/io_sentry_attachment.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/contexts.dart 93.93% <0.00%> (ø)
dart/lib/src/protocol/sentry_operating_system.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/sentry_event.dart 100.00% <0.00%> (ø)
dart/lib/src/transport/rate_limit_parser.dart 95.83% <0.00%> (ø)
...t_processor/enricher/enricher_event_processor.dart 100.00% <0.00%> (ø)
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 295.00 ms 340.52 ms 45.52 ms
Size 6.06 MiB 7.09 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8fa3934 340.64 ms 407.92 ms 67.28 ms
fbf42af 323.04 ms 365.09 ms 42.04 ms
21d4150 379.31 ms 449.23 ms 69.93 ms
08a7b4f 346.47 ms 403.29 ms 56.82 ms
9811573 309.76 ms 402.60 ms 92.84 ms
c70e01a 331.04 ms 401.46 ms 70.42 ms
48e79fd 354.22 ms 391.46 ms 37.24 ms
3637a22 322.59 ms 390.00 ms 67.41 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
6d7a391 331.94 ms 367.04 ms 35.10 ms

App size

Revision Plain With Sentry Diff
8fa3934 6.06 MiB 7.09 MiB 1.03 MiB
fbf42af 5.94 MiB 6.96 MiB 1.02 MiB
21d4150 5.94 MiB 6.97 MiB 1.03 MiB
08a7b4f 5.94 MiB 6.95 MiB 1.01 MiB
9811573 5.94 MiB 6.96 MiB 1.02 MiB
c70e01a 5.94 MiB 6.97 MiB 1.03 MiB
48e79fd 5.94 MiB 6.95 MiB 1.01 MiB
3637a22 6.06 MiB 7.09 MiB 1.03 MiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
6d7a391 5.94 MiB 6.95 MiB 1.01 MiB

Previous results on branch: fix/sync-processed-breadcrumbs

Startup times

Revision Plain With Sentry Diff
f1d95f0 374.73 ms 452.70 ms 77.96 ms

App size

Revision Plain With Sentry Diff
f1d95f0 6.06 MiB 7.09 MiB 1.03 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1269.49 ms 1288.79 ms 19.30 ms
Size 8.10 MiB 9.07 MiB 1000.81 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
21845e2 1279.37 ms 1298.81 ms 19.45 ms
b47809a 1252.61 ms 1278.57 ms 25.96 ms
49a149b 1296.47 ms 1320.20 ms 23.73 ms
5603ab2 1268.47 ms 1280.73 ms 12.26 ms
b728df4 1287.43 ms 1293.94 ms 6.51 ms
21d4150 1252.86 ms 1280.55 ms 27.69 ms
1edf30e 1254.43 ms 1272.82 ms 18.39 ms
ccc09e4 1254.74 ms 1277.08 ms 22.34 ms
a49594a 1284.83 ms 1313.29 ms 28.45 ms
c70e01a 1273.00 ms 1299.12 ms 26.12 ms

App size

Revision Plain With Sentry Diff
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
b47809a 8.16 MiB 9.17 MiB 1.01 MiB
49a149b 8.15 MiB 9.12 MiB 986.26 KiB
5603ab2 8.15 MiB 9.12 MiB 990.57 KiB
b728df4 8.15 MiB 9.15 MiB 1020.72 KiB
21d4150 8.16 MiB 9.17 MiB 1.01 MiB
1edf30e 8.16 MiB 9.17 MiB 1.01 MiB
ccc09e4 8.16 MiB 9.16 MiB 1.01 MiB
a49594a 8.16 MiB 9.16 MiB 1.00 MiB
c70e01a 8.16 MiB 9.17 MiB 1.01 MiB

@marandaneto marandaneto merged commit 69670c9 into main Feb 28, 2023
@marandaneto marandaneto deleted the fix/sync-processed-breadcrumbs branch February 28, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't return a modified breadcrumb via beforeBreadcrumb with copyWith()
2 participants