Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SentryUserInteractionWidget checks if the Elements are mounted before comparing them #1339

Merged
merged 6 commits into from
Mar 17, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 16, 2023

📜 Description

💡 Motivation and Context

Fixes #1338

💚 How did you test it?

Running on Flutter v3.0, Checking Flutter v3.0 source code

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@1ab55fc). Click here to learn what that means.
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1339   +/-   ##
=======================================
  Coverage        ?   90.29%           
=======================================
  Files           ?      170           
  Lines           ?     5273           
  Branches        ?        0           
=======================================
  Hits            ?     4761           
  Misses          ?      512           
  Partials        ?        0           
Impacted Files Coverage Δ
...er_interaction/sentry_user_interaction_widget.dart 95.04% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 330.62 ms 374.90 ms 44.28 ms
Size 6.06 MiB 7.10 MiB 1.04 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
633cf2e 289.36 ms 340.38 ms 51.02 ms
873fb42 352.10 ms 397.43 ms 45.33 ms
6d317ea 303.46 ms 356.06 ms 52.60 ms
04db237 330.16 ms 428.38 ms 98.22 ms
d301b11 337.96 ms 395.04 ms 57.08 ms
ecb4003 332.58 ms 385.15 ms 52.57 ms
6325c3b 339.33 ms 409.86 ms 70.53 ms
1b66358 314.96 ms 363.39 ms 48.43 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
a2ec542 322.27 ms 372.87 ms 50.60 ms

App size

Revision Plain With Sentry Diff
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
873fb42 5.94 MiB 6.96 MiB 1.02 MiB
6d317ea 5.94 MiB 6.92 MiB 1001.74 KiB
04db237 5.94 MiB 6.95 MiB 1.01 MiB
d301b11 6.06 MiB 7.09 MiB 1.03 MiB
ecb4003 6.06 MiB 7.09 MiB 1.03 MiB
6325c3b 5.94 MiB 6.96 MiB 1.02 MiB
1b66358 6.06 MiB 7.09 MiB 1.03 MiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
a2ec542 6.06 MiB 7.10 MiB 1.04 MiB

Previous results on branch: fix/last-element-mounted

Startup times

Revision Plain With Sentry Diff
cac1e4d 306.29 ms 352.81 ms 46.52 ms

App size

Revision Plain With Sentry Diff
cac1e4d 6.06 MiB 7.10 MiB 1.04 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1266.56 ms 1279.04 ms 12.48 ms
Size 8.10 MiB 9.16 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6957bfd 1283.80 ms 1289.00 ms 5.20 ms
134c9f8 1284.48 ms 1306.18 ms 21.70 ms
873fb42 1261.00 ms 1285.92 ms 24.92 ms
5603ab2 1268.47 ms 1280.73 ms 12.26 ms
11fb408 1256.14 ms 1283.51 ms 27.37 ms
a49594a 1284.83 ms 1313.29 ms 28.45 ms
21845e2 1279.37 ms 1298.81 ms 19.45 ms
453e1bc 1294.78 ms 1308.10 ms 13.33 ms
2331d89 1260.86 ms 1281.24 ms 20.39 ms
9811573 1259.78 ms 1278.33 ms 18.55 ms

App size

Revision Plain With Sentry Diff
6957bfd 8.15 MiB 9.15 MiB 1020.71 KiB
134c9f8 8.16 MiB 9.16 MiB 1.01 MiB
873fb42 8.16 MiB 9.17 MiB 1.01 MiB
5603ab2 8.15 MiB 9.12 MiB 990.57 KiB
11fb408 8.10 MiB 9.08 MiB 1004.36 KiB
a49594a 8.16 MiB 9.16 MiB 1.00 MiB
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
453e1bc 8.16 MiB 9.16 MiB 1.00 MiB
2331d89 8.16 MiB 9.17 MiB 1.01 MiB
9811573 8.16 MiB 9.17 MiB 1.01 MiB

Previous results on branch: fix/last-element-mounted

Startup times

Revision Plain With Sentry Diff
cac1e4d 1251.04 ms 1275.17 ms 24.12 ms

App size

Revision Plain With Sentry Diff
cac1e4d 8.10 MiB 9.16 MiB 1.07 MiB

CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto marandaneto merged commit 5aab4c5 into main Mar 17, 2023
@marandaneto marandaneto deleted the fix/last-element-mounted branch March 17, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentryUserInteractionWidget _lastTappedWidget unmounted
2 participants