Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadImageListIntegration won't throw bad state if there is no exceptions in the event #1347

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

marandaneto
Copy link
Contributor

📜 Description

💡 Motivation and Context

Fixes #1345

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 338.17 ms 421.02 ms 82.85 ms
Size 6.06 MiB 7.10 MiB 1.04 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e893df5 310.60 ms 380.58 ms 69.98 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
9c5aec6 287.33 ms 320.94 ms 33.61 ms
0db91cc 327.85 ms 387.31 ms 59.46 ms
d301b11 337.96 ms 395.04 ms 57.08 ms
9928a74 375.26 ms 456.30 ms 81.04 ms
25e9b59 307.00 ms 348.83 ms 41.83 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
11fb408 320.10 ms 380.24 ms 60.14 ms

App size

Revision Plain With Sentry Diff
e893df5 6.06 MiB 7.09 MiB 1.03 MiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB
0db91cc 5.94 MiB 6.95 MiB 1.01 MiB
d301b11 6.06 MiB 7.09 MiB 1.03 MiB
9928a74 5.94 MiB 6.96 MiB 1.02 MiB
25e9b59 5.94 MiB 6.95 MiB 1.01 MiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
11fb408 6.06 MiB 7.10 MiB 1.04 MiB

@marandaneto marandaneto merged commit dd1f7d2 into main Mar 20, 2023
@marandaneto marandaneto deleted the fix/bad-element-symbolication branch March 20, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad state: No element for _NeedsSymbolication.needsSymbolication with v7.1.0
2 participants