Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SentryUserInteractionWidget: add support for PopupMenuButton and PopupMenuItem #1361

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

sstasi95
Copy link
Contributor

@sstasi95 sstasi95 commented Mar 27, 2023

📜 Description

This PR adds support for PopupMenuButton and PopupMenuItem in SentryUserInteractionWidget. In this way, interactions with popup menus are automatically tracked.

Fixes #1360

💡 Motivation and Context

Many widgets are already supported by SentryUserInteractionWidget, but PopupMenuButton and PopupMenuItem currently are not.

💚 How did you test it?

Running flutter test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sstasi95
Can you add a changelog entry?

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -9.03 ⚠️

Comparison is base (8e133ad) 89.75% compared to head (4e69c52) 80.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
- Coverage   89.75%   80.72%   -9.03%     
==========================================
  Files          59       19      -40     
  Lines        2010      633    -1377     
==========================================
- Hits         1804      511    -1293     
+ Misses        206      122      -84     

see 40 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sstasi95
Copy link
Contributor Author

@marandaneto done

@marandaneto marandaneto enabled auto-merge (squash) March 28, 2023 11:13
@marandaneto marandaneto merged commit 0be962b into getsentry:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentryUserInteractionWidget: add support for PopupMenuButton and PopupMenuItem
2 participants