Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove breadcrumbs from transaction to avoid duplication #1366

Merged
merged 7 commits into from
Apr 6, 2023

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Mar 28, 2023

📜 Description

Removes breadcrumbs from transaction for android when scope sync is enabled.

💡 Motivation and Context

Closes #1353

💚 How did you test it?

Tests & ran sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase denrase marked this pull request as ready for review March 28, 2023 14:38
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (b9da046) 89.79% compared to head (beab0f8) 89.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
+ Coverage   89.79%   89.90%   +0.11%     
==========================================
  Files          59      179     +120     
  Lines        2018     5758    +3740     
==========================================
+ Hits         1812     5177    +3365     
- Misses        206      581     +375     
Impacted Files Coverage Δ
dart/lib/src/sentry_client.dart 96.38% <100.00%> (ø)

... and 119 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 352.69 ms 395.61 ms 42.91 ms
Size 6.06 MiB 7.03 MiB 990.44 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2f8f173 323.31 ms 373.29 ms 49.97 ms
ef31c7f 311.39 ms 359.33 ms 47.94 ms
a49594a 282.27 ms 344.84 ms 62.57 ms
ecb4003 332.58 ms 385.15 ms 52.57 ms
8a7f528 290.27 ms 341.80 ms 51.53 ms
e893df5 310.60 ms 380.58 ms 69.98 ms
56810ff 309.72 ms 352.26 ms 42.54 ms
379d7a8 327.10 ms 355.39 ms 28.29 ms
90db9ff 334.86 ms 388.14 ms 53.28 ms
cdf7172 348.54 ms 390.81 ms 42.27 ms

App size

Revision Plain With Sentry Diff
2f8f173 5.94 MiB 6.95 MiB 1.01 MiB
ef31c7f 6.06 MiB 7.09 MiB 1.03 MiB
a49594a 5.94 MiB 6.95 MiB 1.01 MiB
ecb4003 6.06 MiB 7.09 MiB 1.03 MiB
8a7f528 6.06 MiB 7.03 MiB 989.36 KiB
e893df5 6.06 MiB 7.09 MiB 1.03 MiB
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB
379d7a8 5.94 MiB 6.95 MiB 1.01 MiB
90db9ff 6.06 MiB 7.10 MiB 1.04 MiB
cdf7172 5.94 MiB 6.95 MiB 1.01 MiB

Previous results on branch: fix/duplicate-breadcrumbs-in-transaction

Startup times

Revision Plain With Sentry Diff
ace80a3 299.41 ms 354.24 ms 54.83 ms

App size

Revision Plain With Sentry Diff
ace80a3 6.06 MiB 7.03 MiB 990.32 KiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1279.04 ms 1306.94 ms 27.90 ms
Size 8.10 MiB 9.16 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a49594a 1284.83 ms 1313.29 ms 28.45 ms
6957bfd 1283.80 ms 1289.00 ms 5.20 ms
3f23617 1261.93 ms 1286.10 ms 24.17 ms
21845e2 1279.37 ms 1298.81 ms 19.45 ms
873fb42 1261.00 ms 1285.92 ms 24.92 ms
613760b 1263.10 ms 1277.27 ms 14.16 ms
49a149b 1296.47 ms 1320.20 ms 23.73 ms
aed5947 1268.67 ms 1281.10 ms 12.43 ms
ebfead1 1271.57 ms 1284.48 ms 12.91 ms
08a7b4f 1277.10 ms 1303.37 ms 26.27 ms

App size

Revision Plain With Sentry Diff
a49594a 8.16 MiB 9.16 MiB 1.00 MiB
6957bfd 8.15 MiB 9.15 MiB 1020.71 KiB
3f23617 8.16 MiB 9.17 MiB 1.01 MiB
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
873fb42 8.16 MiB 9.17 MiB 1.01 MiB
613760b 8.15 MiB 9.13 MiB 1000.46 KiB
49a149b 8.15 MiB 9.12 MiB 986.26 KiB
aed5947 8.16 MiB 9.17 MiB 1.01 MiB
ebfead1 8.10 MiB 9.16 MiB 1.07 MiB
08a7b4f 8.16 MiB 9.16 MiB 1.01 MiB

@denrase denrase requested a review from marandaneto April 3, 2023 08:38
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denrase

@marandaneto marandaneto merged commit 0ac1eed into main Apr 6, 2023
@marandaneto marandaneto deleted the fix/duplicate-breadcrumbs-in-transaction branch April 6, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate breadcrumbs in transaction event
2 participants