Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachments to Hint #1404

Merged
merged 14 commits into from
Apr 25, 2023
Merged

Add attachments to Hint #1404

merged 14 commits into from
Apr 25, 2023

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Apr 25, 2023

📜 Description

  • Add attachments to Hint

💡 Motivation and Context

Closes #682

💚 How did you test it?

  • Added tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7670e73

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.68 ⚠️

Comparison is base (9949058) 91.46% compared to head (a8e2293) 90.78%.

❗ Current head a8e2293 differs from pull request most recent head 7670e73. Consider uploading reports for the commit 7670e73 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
- Coverage   91.46%   90.78%   -0.68%     
==========================================
  Files         169       61     -108     
  Lines        5296     2041    -3255     
==========================================
- Hits         4844     1853    -2991     
+ Misses        452      188     -264     

see 132 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

dart/lib/src/hint.dart Outdated Show resolved Hide resolved
@denrase denrase marked this pull request as ready for review April 25, 2023 08:07
@marandaneto marandaneto merged commit d85ffe7 into main Apr 25, 2023
@marandaneto marandaneto deleted the feat/hint-attachments branch April 25, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(PR created) Allow attachments to be bound to exception more easily
2 participants