Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback Uri parsing to unknown if its invalid #1414

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 28, 2023

📜 Description

💡 Motivation and Context

#1412

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c4f1621) 90.24% compared to head (09a9113) 90.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1414   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         181      181           
  Lines        5792     5794    +2     
=======================================
+ Hits         5227     5229    +2     
  Misses        565      565           
Impacted Files Coverage Δ
dart/lib/src/utils/url_details.dart 100.00% <100.00%> (ø)
flutter/lib/src/flutter_sentry_attachment.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 338.08 ms 387.96 ms 49.88 ms
Size 6.06 MiB 7.03 MiB 995.72 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
04db237 330.16 ms 428.38 ms 98.22 ms
56810ff 309.72 ms 352.26 ms 42.54 ms
90db9ff 334.86 ms 388.14 ms 53.28 ms
df16b96 326.08 ms 391.82 ms 65.74 ms
3f23617 385.77 ms 476.10 ms 90.33 ms
2331d89 352.45 ms 417.34 ms 64.89 ms
f96ca24 316.08 ms 388.22 ms 72.14 ms
62dde43 339.21 ms 423.06 ms 83.85 ms
e66e71e 296.84 ms 345.43 ms 48.59 ms
e893df5 310.60 ms 380.58 ms 69.98 ms

App size

Revision Plain With Sentry Diff
04db237 5.94 MiB 6.95 MiB 1.01 MiB
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB
90db9ff 6.06 MiB 7.10 MiB 1.04 MiB
df16b96 6.06 MiB 7.03 MiB 988.94 KiB
3f23617 5.94 MiB 6.96 MiB 1.02 MiB
2331d89 5.94 MiB 6.96 MiB 1.02 MiB
f96ca24 6.06 MiB 7.10 MiB 1.04 MiB
62dde43 5.94 MiB 6.96 MiB 1.02 MiB
e66e71e 6.06 MiB 7.09 MiB 1.03 MiB
e893df5 6.06 MiB 7.09 MiB 1.03 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1248.13 ms 1263.29 ms 15.16 ms
Size 8.10 MiB 9.18 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b9da046 1256.43 ms 1275.82 ms 19.39 ms
0be962b 1264.10 ms 1281.16 ms 17.06 ms
55cc6ef 1271.92 ms 1281.04 ms 9.12 ms
aa950e9 1275.17 ms 1295.33 ms 20.16 ms
ebfead1 1271.57 ms 1284.48 ms 12.91 ms
d301b11 1260.61 ms 1272.06 ms 11.45 ms
8d64376 1260.92 ms 1289.32 ms 28.40 ms
9928a74 1249.98 ms 1269.08 ms 19.10 ms
134c9f8 1284.48 ms 1306.18 ms 21.70 ms
fbf42af 1253.76 ms 1269.51 ms 15.76 ms

App size

Revision Plain With Sentry Diff
b9da046 8.10 MiB 9.16 MiB 1.07 MiB
0be962b 8.10 MiB 9.16 MiB 1.07 MiB
55cc6ef 8.10 MiB 9.18 MiB 1.08 MiB
aa950e9 8.16 MiB 9.17 MiB 1.01 MiB
ebfead1 8.10 MiB 9.16 MiB 1.07 MiB
d301b11 8.10 MiB 9.07 MiB 1000.82 KiB
8d64376 8.16 MiB 9.17 MiB 1.01 MiB
9928a74 8.16 MiB 9.17 MiB 1.01 MiB
134c9f8 8.16 MiB 9.16 MiB 1.01 MiB
fbf42af 8.16 MiB 9.17 MiB 1.01 MiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit 1e781fc into main Apr 28, 2023
@krystofwoldrich krystofwoldrich deleted the fix/fallback-uri branch April 28, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants