-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix authority redaction #1424
Fix authority redaction #1424
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.02%
==========================================
Files 181 181
Lines 5794 5788 -6
==========================================
- Hits 5229 5223 -6
Misses 565 565
☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dd1f7d2 | 338.54 ms | 387.10 ms | 48.56 ms |
6957bfd | 325.88 ms | 380.30 ms | 54.43 ms |
a2ec542 | 322.27 ms | 372.87 ms | 50.60 ms |
6e083bb | 327.96 ms | 381.39 ms | 53.43 ms |
b98109e | 296.46 ms | 362.68 ms | 66.22 ms |
5112c69 | 333.67 ms | 363.74 ms | 30.08 ms |
a1a1545 | 295.21 ms | 351.16 ms | 55.95 ms |
68677de | 364.41 ms | 415.61 ms | 51.20 ms |
f2db4ec | 372.46 ms | 469.72 ms | 97.26 ms |
ef31c7f | 311.39 ms | 359.33 ms | 47.94 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dd1f7d2 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
6957bfd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
a2ec542 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
6e083bb | 5.94 MiB | 6.97 MiB | 1.03 MiB |
b98109e | 6.06 MiB | 7.03 MiB | 993.53 KiB |
5112c69 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
a1a1545 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
68677de | 6.06 MiB | 7.10 MiB | 1.04 MiB |
f2db4ec | 6.06 MiB | 7.03 MiB | 990.27 KiB |
ef31c7f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 This looks more robust, now we relay on Darts implementation instead of our own regex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denrase
📜 Description
Use
Uri
APIs to correctly identify and redact user info (authority). Before emails as prot of paths/queries would incorrectly be identifier as user info.💡 Motivation and Context
Closes #1418
Relates to #2690
💚 How did you test it?
Added test
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
Is there something else we need to check?