-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DioEventProcessor: Append http response body #1557
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1557 +/- ##
==========================================
+ Coverage 89.84% 91.19% +1.34%
==========================================
Files 120 61 -59
Lines 3782 2078 -1704
==========================================
- Hits 3398 1895 -1503
+ Misses 384 183 -201
☔ View full report in Codecov by Sentry. |
Also pointed this against the |
@denrase this feature is opt-in, no need for being part of v8, or is there any breaking change? |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
55cc6ef | 300.98 ms | 351.98 ms | 51.00 ms |
2f8f173 | 323.31 ms | 373.29 ms | 49.97 ms |
0a23f98 | 377.19 ms | 416.18 ms | 39.00 ms |
ebfead1 | 298.44 ms | 374.28 ms | 75.84 ms |
b47809a | 333.42 ms | 368.36 ms | 34.95 ms |
5aab4c5 | 326.12 ms | 378.82 ms | 52.70 ms |
0aaa46e | 313.39 ms | 373.23 ms | 59.85 ms |
f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
40680d3 | 323.55 ms | 390.29 ms | 66.73 ms |
519423f | 357.00 ms | 415.77 ms | 58.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
55cc6ef | 6.06 MiB | 7.03 MiB | 995.45 KiB |
2f8f173 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
0a23f98 | 6.06 MiB | 7.03 MiB | 996.97 KiB |
ebfead1 | 6.06 MiB | 7.03 MiB | 989.24 KiB |
b47809a | 5.94 MiB | 6.96 MiB | 1.02 MiB |
5aab4c5 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
0aaa46e | 6.16 MiB | 7.14 MiB | 1007.32 KiB |
f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
40680d3 | 6.06 MiB | 7.03 MiB | 989.25 KiB |
519423f | 6.06 MiB | 7.03 MiB | 989.24 KiB |
Previous results on branch: feat/append-http-response-body
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
101e319 | 312.72 ms | 376.50 ms | 63.78 ms |
67cd866 | 296.11 ms | 365.72 ms | 69.61 ms |
642c435 | 323.16 ms | 381.92 ms | 58.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
101e319 | 6.16 MiB | 7.14 MiB | 1007.46 KiB |
67cd866 | 6.16 MiB | 7.14 MiB | 1007.32 KiB |
642c435 | 6.16 MiB | 7.14 MiB | 1004.21 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e094d3 | 1237.54 ms | 1243.51 ms | 5.97 ms |
a1a1545 | 1270.85 ms | 1289.82 ms | 18.96 ms |
aed5947 | 1268.67 ms | 1281.10 ms | 12.43 ms |
1b66358 | 1260.81 ms | 1282.08 ms | 21.27 ms |
2d3b03d | 1258.19 ms | 1272.69 ms | 14.50 ms |
11fb408 | 1256.14 ms | 1283.51 ms | 27.37 ms |
1131914 | 1277.20 ms | 1300.20 ms | 23.00 ms |
3a69405 | 1292.84 ms | 1303.96 ms | 11.12 ms |
d301b11 | 1260.61 ms | 1272.06 ms | 11.45 ms |
dd1f7d2 | 1263.16 ms | 1275.15 ms | 11.99 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e094d3 | 8.29 MiB | 9.37 MiB | 1.08 MiB |
a1a1545 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
aed5947 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
1b66358 | 8.10 MiB | 9.08 MiB | 1004.35 KiB |
2d3b03d | 8.10 MiB | 9.07 MiB | 1000.83 KiB |
11fb408 | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
1131914 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
3a69405 | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
d301b11 | 8.10 MiB | 9.07 MiB | 1000.82 KiB |
dd1f7d2 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
📜 Description
DioEventProcessor
if allowed by options💡 Motivation and Context
Relates to #624
💚 How did you test it?
Added tests
📝 Checklist
sendDefaultPii
is enabled