-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Android & iOS CI issues #1627
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,19 +59,20 @@ jobs: | |
path: | | ||
~/.android/avd/* | ||
~/.android/adb* | ||
key: avd-21 | ||
key: avd-31 | ||
|
||
- name: create AVD and generate snapshot for caching | ||
if: steps.avd-cache.outputs.cache-hit != 'true' | ||
uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b #[email protected] | ||
with: | ||
working-directory: ./flutter/example | ||
api-level: 21 | ||
force-avd-creation: false | ||
emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none | ||
disable-animations: false | ||
arch: x86_64 | ||
api-level: 31 | ||
profile: Nexus 6 | ||
arch: x86_64 | ||
force-avd-creation: false | ||
avd-name: macOS-avd-x86_64-31 | ||
emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none | ||
disable-animations: true | ||
script: echo 'Generated AVD snapshot for caching.' | ||
|
||
- name: build apk | ||
|
@@ -82,24 +83,26 @@ jobs: | |
uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b #[email protected] | ||
with: | ||
working-directory: ./flutter/example/android | ||
api-level: 21 | ||
api-level: 31 | ||
profile: Nexus 6 | ||
arch: x86_64 | ||
force-avd-creation: false | ||
avd-name: macOS-avd-x86_64-31 | ||
emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none | ||
disable-animations: true | ||
arch: x86_64 | ||
profile: Nexus 6 | ||
script: ./gradlew testDebugUnitTest | ||
|
||
- name: launch android emulator & run android integration test | ||
uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b #[email protected] | ||
with: | ||
working-directory: ./flutter/example | ||
api-level: 21 | ||
api-level: 31 | ||
profile: Nexus 6 | ||
arch: x86_64 | ||
force-avd-creation: false | ||
avd-name: macOS-avd-x86_64-31 | ||
emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none | ||
disable-animations: true | ||
arch: x86_64 | ||
profile: Nexus 6 | ||
script: flutter test integration_test/integration_test.dart --verbose | ||
|
||
test-ios: | ||
|
@@ -134,7 +137,7 @@ jobs: | |
- name: launch ios simulator | ||
id: sim | ||
run: | | ||
simulator_id=$(xcrun simctl create sentryPhone com.apple.CoreSimulator.SimDeviceType.iPhone-14 com.apple.CoreSimulator.SimRuntime.iOS-16-2) | ||
simulator_id=$(xcrun simctl create sentryPhone com.apple.CoreSimulator.SimDeviceType.iPhone-14 com.apple.CoreSimulator.SimRuntime.iOS-16-4) | ||
echo "SIMULATOR_ID=${simulator_id}" >> "$GITHUB_OUTPUT" | ||
xcrun simctl boot ${simulator_id} | ||
# Disable flutter integration tests because of flaky execution | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't it work with api-level 21 anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have a test where we check build with min version. Figured the more recent emulators might give us better performance and stability.