ci: generate code coverage in flutter integration test #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
https://app.codecov.io/gh/getsentry/sentry-dart/pull/1667/tree/flutter I think the coverage report will only try to match coverage within the same subproject so in your changes it would try to match coverage within flutter/example which I assume we don't want. There are also no coverage changes for flutter/lib and dart/lib compared to the base branch so I don't think this works in its current state |
|
I agree, let's close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code coverage reporting to integration tests, with hopes of getting reports on coverage of cocoa FFI briding code in #1611
Not sure if this actually works - can someone who understands codecov UI check if the change looks as expected?