Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump natiginfo/action-detekt-all from 1.21.0 to 1.23.1 #1684

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Bump natiginfo/action-detekt-all from 1.21.0 to 1.23.1 #1684

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1811b0a
Bump natiginfo/action-detekt-all from 1.21.0 to 1.23.1
dependabot[bot] Oct 17, 2023
ea72413
Merge branch 'main' into dependabot/github_actions/natiginfo/action-d…
buenaflor Oct 25, 2023
b5f8fcd
Merge branch 'main' into dependabot/github_actions/natiginfo/action-d…
buenaflor Nov 3, 2023
e531292
fix braces
buenaflor Nov 3, 2023
96aa27a
Add missing trailing comma
buenaflor Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/flutter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,6 @@ jobs:
steps:
- uses: actions/checkout@v4
# To recreate baseline run: detekt -i flutter/android,flutter/example/android -b flutter/config/detekt-bl.xml -cb
- uses: natiginfo/action-detekt-all@e01de6ff0eef7c24131e8a133bf598cfac6ceeab # pin@1.21.0
- uses: natiginfo/action-detekt-all@be3c18799c7c392b2f41a674beed9ced7ae2f21b # pin@1.23.1
with:
args: -i flutter/android,flutter/example/android --baseline flutter/config/detekt-bl.xml --jvm-target 1.8 --build-upon-default-config --all-rules
38 changes: 17 additions & 21 deletions flutter/example/android/app/src/main/kotlin/io/sentry/samples/flutter/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,37 +11,33 @@ class MainActivity : FlutterActivity() {

override fun configureFlutterEngine(flutterEngine: FlutterEngine) {
super.configureFlutterEngine(flutterEngine)
MethodChannel(flutterEngine.dartExecutor.binaryMessenger, _channel).setMethodCallHandler {
call, result ->
MethodChannel(
flutterEngine.dartExecutor.binaryMessenger,
_channel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"

).setMethodCallHandler { call, result ->
// Note: this method is invoked on the main thread.
when (call.method) {
"throw" -> {
"throw" ->
thread(isDaemon = true) {
throw Exception("Catch this java exception thrown from Kotlin thread!")
}
}
"anr" -> {
Thread.sleep(6_000)
}
"capture" -> {

"anr" -> Thread.sleep(6_000)

"capture" ->
try {
throw RuntimeException("Catch this java exception!")
} catch (e: Exception) {
Sentry.captureException(e)
}
}
"crash" -> {
crash()
}
"cpp_capture_message" -> {
message()
}
"platform_exception" -> {
throw RuntimeException("Catch this platform exception!")
}
else -> {
result.notImplemented()
}

"crash" -> crash()

"cpp_capture_message" -> message()

"platform_exception" -> throw RuntimeException("Catch this platform exception!")

else -> result.notImplemented()
}
result.success("")
}
Expand Down