Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting and analyze ci issues #1733

Merged
merged 4 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion drift/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@
Sentry integration for `drift` package
===========

| package | build | pub | likes | popularity | pub points |
|-------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------| ------- |
| sentry_drift | [![build](https://github.com/getsentry/sentry-dart/workflows/sentry-drift/badge.svg?branch=main)](https://github.com/getsentry/sentry-dart/actions?query=workflow%3Asentry-drift) | [![pub package](https://img.shields.io/pub/v/sentry_drift.svg)](https://pub.dev/packages/sentry_drift) | [![likes](https://img.shields.io/pub/likes/sentry_drift)](https://pub.dev/packages/sentry_drift/score) | [![popularity](https://img.shields.io/pub/popularity/sentry_drift)](https://pub.dev/packages/sentry_drift/score) | [![pub points](https://img.shields.io/pub/points/sentry_drift)](https://pub.dev/packages/sentry_drift/score)

Integration for the [`drift`](https://pub.dev/packages/drift) package.

#### Usage

- Sign up for a Sentry.io account and get a DSN at https://sentry.io.

- Follow the installing instructions on [pub.dev](https://pub.dev/packages/sentry/install).
Expand All @@ -22,7 +30,7 @@ import 'package:drift/native.dart';
import 'package:sentry/sentry.dart';
import 'package:sentry_drift/sentry_drift.dart';

import '../test/test_database.dart';
import 'your_database.dart';

Future<void> main() async {
// ATTENTION: Change the DSN below with your own to see the events in Sentry. Get one at sentry.io
Expand Down
1 change: 0 additions & 1 deletion drift/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ analyzer:
deprecated_member_use_from_same_package: warning
# ignore sentry/path on pubspec as we change it on deployment
invalid_dependency: ignore
unnecessary_import: ignore
exclude:
- example/**
- test/mocks/mocks.mocks.dart
Expand Down
1 change: 0 additions & 1 deletion drift/lib/src/sentry_query_executor.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import 'dart:async';

import 'package:drift/backends.dart';
import 'package:drift/drift.dart';
import 'package:meta/meta.dart';
import 'package:sentry/sentry.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,16 +139,15 @@
return <String, String>{
'has_render_view': hasRenderView.toString(),
if (tempDebugBrightnessOverride != null)
'debug_brightness_override': describeEnum(tempDebugBrightnessOverride),
'debug_brightness_override': tempDebugBrightnessOverride.name,

Check warning on line 142 in flutter/lib/src/event_processor/flutter_enricher_event_processor.dart

View check run for this annotation

Codecov / codecov/patch

flutter/lib/src/event_processor/flutter_enricher_event_processor.dart#L142

Added line #L142 was not covered by tests
if (debugPlatformOverride != null)
'debug_default_target_platform_override':
describeEnum(debugPlatformOverride),
'debug_default_target_platform_override': debugPlatformOverride.name,

Check warning on line 144 in flutter/lib/src/event_processor/flutter_enricher_event_processor.dart

View check run for this annotation

Codecov / codecov/patch

flutter/lib/src/event_processor/flutter_enricher_event_processor.dart#L144

Added line #L144 was not covered by tests
if (initialLifecycleState != null && initialLifecycleState.isNotEmpty)
'initial_lifecycle_state': initialLifecycleState,
if (defaultRouteName != null && defaultRouteName.isNotEmpty)
'default_route_name': defaultRouteName,
if (currentLifecycle != null)
'current_lifecycle_state': describeEnum(currentLifecycle),
'current_lifecycle_state': currentLifecycle.name,
// Seems to always return false.
// Also always fails in tests.
// See https://github.com/flutter/flutter/issues/83919
Expand Down
23 changes: 10 additions & 13 deletions flutter/lib/src/native/cocoa/binding.dart
Original file line number Diff line number Diff line change
Expand Up @@ -37603,8 +37603,7 @@ class ObjCBlock_bool_ObjCObject_ffiUnsignedLong_bool extends _ObjCBlockBase {
ObjCBlock_bool_ObjCObject_ffiUnsignedLong_bool.fromFunctionPointer(
SentryCocoa lib,
ffi.Pointer<
ffi
.NativeFunction<
ffi.NativeFunction<
ffi.Bool Function(ffi.Pointer<ObjCObject> arg0,
ffi.UnsignedLong arg1, ffi.Pointer<ffi.Bool> arg2)>>
ptr)
Expand Down Expand Up @@ -42032,17 +42031,15 @@ class ObjCBlock_bool_ObjCObject_bool extends _ObjCBlockBase {
ffi.Pointer<ffi.Bool> arg1)>>
ptr)
: this._(
lib
._newBlock1(
_cFuncTrampoline ??= ffi.Pointer.fromFunction<
ffi.Bool Function(
ffi.Pointer<_ObjCBlock> block,
ffi.Pointer<ObjCObject> arg0,
ffi.Pointer<ffi.Bool> arg1)>(
_ObjCBlock_bool_ObjCObject_bool_fnPtrTrampoline,
false)
.cast(),
ptr.cast()),
lib._newBlock1(
_cFuncTrampoline ??= ffi.Pointer.fromFunction<
ffi.Bool Function(
ffi.Pointer<_ObjCBlock> block,
ffi.Pointer<ObjCObject> arg0,
ffi.Pointer<ffi.Bool> arg1)>(
_ObjCBlock_bool_ObjCObject_bool_fnPtrTrampoline, false)
.cast(),
ptr.cast()),
lib);
static ffi.Pointer<ffi.Void>? _cFuncTrampoline;

Expand Down