Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8 prep: merge main into 8.0.0 branch #1871
v8 prep: merge main into 8.0.0 branch #1871
Changes from 174 commits
5f6cc37
78eeed5
d312548
1d47eb7
280ab9f
9442665
4ad2751
6852b33
c9d3212
df7b257
9d43f71
f124efc
7c822cd
8fe0817
5aa047a
d53c6fa
bdd1a23
ffae3e3
c732386
7129102
3e4b523
03fc2a6
7f75f32
da14c18
cd16818
21f1bf7
d10745a
afa6e2a
42f6e7e
746a779
5f3facd
2211a40
9d05a05
1a93825
daa1b33
2ba6efd
dfa585e
64e4616
f83bc1d
edb78ed
6d17400
26e955b
583711d
5e612d5
d226fd8
677b331
dc54bfc
ed2ae08
891efac
0eb0b26
481e262
30c1193
3de8b9b
2261c15
955541a
bd37365
bb6945a
a775d3f
9aa4e24
2de6d6f
64af39c
9f05645
f6f3d25
2d4fd8b
8a10ab7
212d6c7
452c92a
bdc7f93
655559e
a97ee7c
48adddf
051e97a
3e5078c
7748b7c
b4aa843
636cb61
0026762
137698e
8609bd8
408bdab
67a0238
0caa911
9de6425
683fd34
a6940c1
25161f4
dd08ebb
14950f1
b6eb979
6fe4fab
a971204
041d84d
d4120ac
886fc8c
8fb602f
9220bb8
3f3ef0b
4829ad3
f25f207
4b3af28
47664e3
2d74010
d3801f8
13446e1
d5f600b
13c328d
9d7e862
e5c9171
4b29d6e
d914f35
d8519f9
117d988
f27dcdf
f649a83
f275487
3ad66e4
0118295
bc29768
7ea3931
4be7ec8
be08ed1
33ed16d
730365e
404d19f
bde5f6b
ca7f531
f12d09d
1cdcacf
d0312c9
92562b3
24b6e60
552c543
d68bee7
7551d29
294b7f0
270031a
f770c4c
b4b36f5
4477d2e
2f0d415
920ec41
7e4a1ec
bd1b990
4133230
e3ef570
4327577
21bf0de
fb77dcf
c3e6c82
42b79b3
f2e496d
4c78360
147ef50
8e4eeb3
74e1fdd
36615c3
1ac008b
e6dd065
cdd9dbd
ba9c106
ffe46ae
e8ed5a0
91ff12f
c5e18b8
1cc62d2
be59865
beedc6a
77f76f5
6f57f15
3c11fd1
8de8e1a
112ec65
41009be
5196903
651ebf5
3a5faf2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, just a generic nit. I think it would make sense to keep
## Unreleased
instead of## 8.0.0
as likely it will be released as alpha or beta first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the plan is to fork the releaase 8.0.0 again to a 8.0.0 beta branch and release that one if that makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so merge this pr into release 8.0.0 -> fork to release 8.0.0-beta.1 -> trigger release 8.0.0.beta.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but true, if I start a beta release from the v8 branch then it needs to be unreleased