Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other metric types and weight (part 2) #1949

Merged
merged 7 commits into from
Apr 4, 2024

Add timing metric and beforeMetric callback (part 3) (#1954)

d93ace2
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add other metric types and weight (part 2) #1949

Add timing metric and beforeMetric callback (part 3) (#1954)
d93ace2
Select commit
Loading
Failed to load commit list.
GitHub Actions / Analysis of sentry_flutter succeeded Apr 4, 2024 in 2m 6s

Package analysis results for sentry_flutter

Score

140/140 points
(100.0%)

Supported platforms

  • Flutter
    • android
    • ios
    • windows
    • linux
    • macos
    • web

Details

Follow Dart file conventions (30/30)

✔ 10/10 points: Provide a valid pubspec.yaml

✔ 5/5 points: Provide a valid README.md

✔ 5/5 points: Provide a valid CHANGELOG.md

✔ 10/10 points: Use an OSI-approved license

Detected license: MIT.

Provide documentation (20/20)

✔ 10/10 points: 20% or more of the public API has dartdoc comments

743 out of 1136 API elements (65.4 %) have documentation comments.

Some symbols that are missing documentation: sentry_flutter.AdditionalInfoExtractor, sentry_flutter.Breadcrumb.Breadcrumb.console, sentry_flutter.Breadcrumb.copyWith, sentry_flutter.Breadcrumb.Breadcrumb.http, sentry_flutter.Breadcrumb.Breadcrumb.userInteraction.

✔ 10/10 points: Package has an example

Platform support (20/20)

✔ 20/20 points: Supports 6 of 6 possible platforms (iOS, Android, Web, Windows, macOS, Linux)

  • ✓ Android
  • ✓ iOS
  • ✓ Windows
  • ✓ Linux
  • ✓ macOS
  • ✓ Web

These issues are present but do not affect the score, because they may not originate in your package:

Package does not support platform `Android`.

Because:

  • package:sentry_flutter/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/integrations/on_error_integration.dart that imports:
  • package:sentry_flutter/src/sentry_flutter_options.dart that imports:
  • package:sentry_flutter/src/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/event_processor/flutter_enricher_event_processor.dart that imports:
  • package:sentry_flutter/src/navigation/sentry_navigator_observer.dart that imports:
  • package:sentry_flutter/src/integrations/integrations.dart that imports:
  • package:sentry_flutter/src/integrations/load_release_integration.dart that imports:
  • package:package_info_plus/package_info_plus.dart that imports:
  • package:package_info_plus/src/package_info_plus_windows.dart that imports:
  • package:package_info_plus/src/file_version_info.dart that imports:
  • package:win32/win32.dart that declares support for platforms: Windows.
Package does not support platform `iOS`.

Because:

  • package:sentry_flutter/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/integrations/on_error_integration.dart that imports:
  • package:sentry_flutter/src/sentry_flutter_options.dart that imports:
  • package:sentry_flutter/src/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/event_processor/flutter_enricher_event_processor.dart that imports:
  • package:sentry_flutter/src/navigation/sentry_navigator_observer.dart that imports:
  • package:sentry_flutter/src/integrations/integrations.dart that imports:
  • package:sentry_flutter/src/integrations/load_release_integration.dart that imports:
  • package:package_info_plus/package_info_plus.dart that imports:
  • package:package_info_plus/src/package_info_plus_windows.dart that imports:
  • package:package_info_plus/src/file_version_info.dart that imports:
  • package:win32/win32.dart that declares support for platforms: Windows.
Package does not support platform `Linux`.

Because:

  • package:sentry_flutter/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/integrations/on_error_integration.dart that imports:
  • package:sentry_flutter/src/sentry_flutter_options.dart that imports:
  • package:sentry_flutter/src/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/event_processor/flutter_enricher_event_processor.dart that imports:
  • package:sentry_flutter/src/navigation/sentry_navigator_observer.dart that imports:
  • package:sentry_flutter/src/integrations/integrations.dart that imports:
  • package:sentry_flutter/src/integrations/load_release_integration.dart that imports:
  • package:package_info_plus/package_info_plus.dart that imports:
  • package:package_info_plus/src/package_info_plus_windows.dart that imports:
  • package:package_info_plus/src/file_version_info.dart that imports:
  • package:win32/win32.dart that declares support for platforms: Windows.
Package does not support platform `macOS`.

Because:

  • package:sentry_flutter/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/integrations/on_error_integration.dart that imports:
  • package:sentry_flutter/src/sentry_flutter_options.dart that imports:
  • package:sentry_flutter/src/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/event_processor/flutter_enricher_event_processor.dart that imports:
  • package:sentry_flutter/src/navigation/sentry_navigator_observer.dart that imports:
  • package:sentry_flutter/src/integrations/integrations.dart that imports:
  • package:sentry_flutter/src/integrations/load_release_integration.dart that imports:
  • package:package_info_plus/package_info_plus.dart that imports:
  • package:package_info_plus/src/package_info_plus_windows.dart that imports:
  • package:package_info_plus/src/file_version_info.dart that imports:
  • package:win32/win32.dart that declares support for platforms: Windows.
Package not compatible with platform Web

Because:

  • package:sentry_flutter/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/integrations/on_error_integration.dart that imports:
  • package:sentry_flutter/src/sentry_flutter_options.dart that imports:
  • package:sentry_flutter/src/sentry_flutter.dart that imports:
  • package:sentry_flutter/src/event_processor/flutter_enricher_event_processor.dart that imports:
  • package:sentry_flutter/src/navigation/sentry_navigator_observer.dart that imports:
  • package:sentry_flutter/src/integrations/integrations.dart that imports:
  • package:sentry_flutter/src/integrations/load_release_integration.dart that imports:
  • package:package_info_plus/package_info_plus.dart that imports:
  • package:package_info_plus/src/package_info_plus_linux.dart that imports:
  • dart:io

Pass static analysis (50/50)

✔ 50/50 points: code has no errors, warnings, lints, or formatting issues

Support up-to-date dependencies (20/20)

✔ 10/10 points: All of the package dependencies are supported in the latest version

Package Constraint Compatible Latest
ffi ^2.0.0 2.1.2 2.1.2
flutter flutter 0.0.0 0.0.0
flutter_web_plugins flutter 0.0.0 0.0.0
meta ^1.3.0 1.11.0 1.14.0
package_info_plus >=1.0.0 <=5.0.1 4.2.0 6.0.0
sentry /github/workspace/dart 7.18.0 7.18.0
Transitive dependencies
Package Constraint Compatible Latest
async - 2.11.0 2.11.0
characters - 1.3.0 1.3.0
collection - 1.18.0 1.18.0
crypto - 3.0.3 3.0.3
fixnum - 1.1.0 1.1.0
http - 1.2.1 1.2.1
http_parser - 4.0.2 4.0.2
material_color_utilities - 0.8.0 0.11.1
package_info_plus_platform_interface - 2.0.1 2.0.1
path - 1.9.0 1.9.0
plugin_platform_interface - 2.1.8 2.1.8
sky_engine - 0.0.99 0.0.99
source_span - 1.10.0 1.10.0
sprintf - 7.0.0 7.0.0
stack_trace - 1.11.1 1.11.1
string_scanner - 1.2.0 1.2.0
term_glyph - 1.2.1 1.2.1
typed_data - 1.3.2 1.3.2
uuid - 4.3.3 4.3.3
vector_math - 2.1.4 2.1.4
web - 0.5.1 0.5.1
win32 - 5.4.0 5.4.0

To reproduce run dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides.

The constraint `>=1.0.0 <=5.0.1` on package_info_plus does not support the stable version `6.0.0`, that was published 15 days ago.

When package_info_plus is 30 days old, this package will no longer be awarded points in this category.

Try running dart pub upgrade --major-versions package_info_plus to update the constraint.

✔ 10/10 points: Package supports latest stable Dart and Flutter SDKs

Versions