Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App start: native spans #2027

Merged
merged 52 commits into from
May 9, 2024
Merged

App start: native spans #2027

merged 52 commits into from
May 9, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented May 2, 2024

📜 Description

Adds native spans to app start transaction

Blocked by

💡 Motivation and Context

Improve app start transaction and give insight into the native layer times

💚 How did you test it?

Unit, Manual with spotlight

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor marked this pull request as ready for review May 6, 2024 11:19
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a detail, but good for the rest!

@buenaflor
Copy link
Contributor Author

@stefanosiano I've updated the span description to Before Sentry Init Setup

@stefanosiano
Copy link
Member

ok, last thing and can be merged 👍

@buenaflor buenaflor merged commit 4656f10 into main May 9, 2024
44 checks passed
@buenaflor buenaflor deleted the feat/app-start-native-spans branch May 9, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants