-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App start: native spans #2027
Merged
Merged
App start: native spans #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
buenaflor
commented
May 6, 2024
stefanosiano
reviewed
May 8, 2024
stefanosiano
reviewed
May 8, 2024
stefanosiano
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a detail, but good for the rest!
@stefanosiano I've updated the span description to |
stefanosiano
reviewed
May 9, 2024
ok, last thing and can be merged 👍 |
Co-authored-by: Stefano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds native spans to app start transaction
Blocked by
💡 Motivation and Context
Improve app start transaction and give insight into the native layer times
💚 How did you test it?
Unit, Manual with spotlight
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps