Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api for pausing/resuming cocoa app hang tracking #2134

Merged
merged 11 commits into from
Jun 26, 2024
Merged

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jun 25, 2024

📜 Description

Allows users to control the app hang tracking.

This might be important to prevent the Cocoa SDK from reporting wrongly detected app hangs when the OS shows a system dialog for asking specific permissions.

💡 Motivation and Context

Closes #2116

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Tasks

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add api for pausing/resuming cocoa app hang tracking ([#2134](https://github.com/getsentry/sentry-dart/pull/2134))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 9952c98

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (98d9a4a) to head (8bfd99d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2134      +/-   ##
==========================================
+ Coverage   88.41%   91.99%   +3.58%     
==========================================
  Files         224       62     -162     
  Lines        7705     2036    -5669     
==========================================
- Hits         6812     1873    -4939     
+ Misses        893      163     -730     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 360.96 ms 427.84 ms 66.88 ms
Size 6.35 MiB 7.35 MiB 1017.84 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
56810ff 309.72 ms 352.26 ms 42.54 ms
3e33891 313.60 ms 379.51 ms 65.91 ms
fe4aa56 356.06 ms 428.67 ms 72.61 ms
8cb6557 321.20 ms 370.46 ms 49.26 ms
a510d1d 295.63 ms 344.65 ms 49.03 ms
f275487 369.08 ms 432.44 ms 63.36 ms
689d2fd 378.62 ms 430.48 ms 51.86 ms
746a779 347.94 ms 385.71 ms 37.78 ms
d189e01 328.67 ms 397.12 ms 68.45 ms
5603ab2 309.84 ms 345.20 ms 35.36 ms

App size

Revision Plain With Sentry Diff
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB
3e33891 6.16 MiB 7.14 MiB 1007.46 KiB
fe4aa56 6.06 MiB 7.10 MiB 1.04 MiB
8cb6557 6.06 MiB 7.03 MiB 997.01 KiB
a510d1d 5.94 MiB 6.96 MiB 1.02 MiB
f275487 6.33 MiB 7.26 MiB 947.03 KiB
689d2fd 6.06 MiB 7.10 MiB 1.04 MiB
746a779 6.27 MiB 7.20 MiB 956.05 KiB
d189e01 6.16 MiB 7.14 MiB 1009.90 KiB
5603ab2 5.94 MiB 6.95 MiB 1.01 MiB

Previous results on branch: feat/app-hang-api

Startup times

Revision Plain With Sentry Diff
9169adf 350.73 ms 429.04 ms 78.31 ms
ae718d9 440.10 ms 557.26 ms 117.16 ms

App size

Revision Plain With Sentry Diff
9169adf 6.35 MiB 7.35 MiB 1017.84 KiB
ae718d9 6.35 MiB 7.35 MiB 1017.84 KiB

Copy link
Contributor

github-actions bot commented Jun 25, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.77 ms 1236.53 ms 3.77 ms
Size 8.33 MiB 9.62 MiB 1.29 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7273303 1246.50 ms 1262.06 ms 15.56 ms
3a43905 1254.31 ms 1266.35 ms 12.04 ms
be8cafe 1239.94 ms 1266.20 ms 26.27 ms
f96ca24 1264.39 ms 1287.98 ms 23.59 ms
26e955b 1232.35 ms 1258.88 ms 26.52 ms
4b943a1 1250.23 ms 1262.28 ms 12.05 ms
d61cecf 1276.96 ms 1290.02 ms 13.06 ms
683fd34 1239.83 ms 1259.08 ms 19.25 ms
e66e71e 1273.55 ms 1291.63 ms 18.08 ms
c73ab67 1267.73 ms 1279.36 ms 11.63 ms

App size

Revision Plain With Sentry Diff
7273303 8.33 MiB 9.40 MiB 1.07 MiB
3a43905 8.10 MiB 9.18 MiB 1.08 MiB
be8cafe 8.33 MiB 9.40 MiB 1.07 MiB
f96ca24 8.10 MiB 9.08 MiB 1004.36 KiB
26e955b 8.28 MiB 9.34 MiB 1.05 MiB
4b943a1 8.33 MiB 9.40 MiB 1.07 MiB
d61cecf 8.10 MiB 9.18 MiB 1.08 MiB
683fd34 8.28 MiB 9.34 MiB 1.06 MiB
e66e71e 8.10 MiB 9.08 MiB 1004.36 KiB
c73ab67 8.29 MiB 9.36 MiB 1.07 MiB

Previous results on branch: feat/app-hang-api

Startup times

Revision Plain With Sentry Diff
9169adf 1251.12 ms 1278.11 ms 26.98 ms
ae718d9 1251.88 ms 1273.29 ms 21.41 ms

App size

Revision Plain With Sentry Diff
9169adf 8.33 MiB 9.62 MiB 1.29 MiB
ae718d9 8.33 MiB 9.62 MiB 1.29 MiB

@buenaflor buenaflor marked this pull request as ready for review June 26, 2024 11:11
Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@buenaflor buenaflor merged commit 66e0270 into main Jun 26, 2024
41 of 42 checks passed
@buenaflor buenaflor deleted the feat/app-hang-api branch June 26, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an API that pauses/resumes reporting app hangs
2 participants