-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app starts hanging for 30s #2140
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
+ Coverage 88.42% 92.05% +3.62%
==========================================
Files 224 62 -162
Lines 7717 2038 -5679
==========================================
- Hits 6824 1876 -4948
+ Misses 893 162 -731 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6034b0a | 406.35 ms | 475.93 ms | 69.59 ms |
6d317ea | 303.46 ms | 356.06 ms | 52.60 ms |
6957bfd | 325.88 ms | 380.30 ms | 54.43 ms |
78eeed5 | 298.35 ms | 361.63 ms | 63.28 ms |
7f2b01d | 304.94 ms | 345.71 ms | 40.78 ms |
1c6eb5b | 350.69 ms | 393.86 ms | 43.17 ms |
c9d3212 | 301.34 ms | 361.58 ms | 60.24 ms |
08a7b4f | 346.47 ms | 403.29 ms | 56.82 ms |
62de927 | 313.81 ms | 358.15 ms | 44.34 ms |
1131914 | 317.90 ms | 361.58 ms | 43.69 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6034b0a | 6.34 MiB | 7.29 MiB | 970.36 KiB |
6d317ea | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
6957bfd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
78eeed5 | 6.16 MiB | 7.14 MiB | 1009.97 KiB |
7f2b01d | 5.94 MiB | 6.95 MiB | 1.01 MiB |
1c6eb5b | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
c9d3212 | 6.16 MiB | 7.14 MiB | 1010.90 KiB |
08a7b4f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
62de927 | 6.15 MiB | 7.11 MiB | 981.78 KiB |
1131914 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
Previous results on branch: fix/app-starts-hanging
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
37bd836 | 410.32 ms | 491.77 ms | 81.45 ms |
99f2252 | 379.71 ms | 451.43 ms | 71.71 ms |
03fe717 | 397.83 ms | 466.73 ms | 68.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
37bd836 | 6.35 MiB | 7.35 MiB | 1017.77 KiB |
99f2252 | 6.35 MiB | 7.35 MiB | 1017.77 KiB |
03fe717 | 6.35 MiB | 7.35 MiB | 1017.76 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5112c69 | 1272.76 ms | 1293.37 ms | 20.61 ms |
89ea268 | 1252.33 ms | 1253.58 ms | 1.26 ms |
be173fa | 1364.84 ms | 1424.49 ms | 59.65 ms |
3334ac1 | 1259.22 ms | 1275.40 ms | 16.17 ms |
0a82a1e | 1233.56 ms | 1244.56 ms | 11.00 ms |
abcdba3 | 1257.31 ms | 1283.49 ms | 26.18 ms |
4b5a4f6 | 1245.28 ms | 1272.27 ms | 26.99 ms |
3de8b9b | 1234.22 ms | 1251.94 ms | 17.72 ms |
6a40d32 | 1253.50 ms | 1266.49 ms | 12.99 ms |
d8519f9 | 1208.57 ms | 1229.80 ms | 21.22 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5112c69 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
89ea268 | 8.09 MiB | 9.16 MiB | 1.06 MiB |
be173fa | 8.33 MiB | 9.54 MiB | 1.22 MiB |
3334ac1 | 8.10 MiB | 9.17 MiB | 1.08 MiB |
0a82a1e | 8.29 MiB | 9.37 MiB | 1.08 MiB |
abcdba3 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
4b5a4f6 | 8.32 MiB | 9.39 MiB | 1.07 MiB |
3de8b9b | 8.28 MiB | 9.34 MiB | 1.06 MiB |
6a40d32 | 8.29 MiB | 9.37 MiB | 1.08 MiB |
d8519f9 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
Previous results on branch: fix/app-starts-hanging
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
99f2252 | 1251.37 ms | 1269.87 ms | 18.50 ms |
03fe717 | 1248.22 ms | 1270.33 ms | 22.11 ms |
37bd836 | 1240.71 ms | 1258.24 ms | 17.53 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
99f2252 | 8.33 MiB | 9.62 MiB | 1.29 MiB |
03fe717 | 8.33 MiB | 9.62 MiB | 1.29 MiB |
37bd836 | 8.33 MiB | 9.62 MiB | 1.29 MiB |
I will test this later today. |
Verified with Spotlight that this works for my use case 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good! 🚀
📜 Description
Fixes timeouts still happening with autoAppStarts disabled and setAppStartEnd not being called
Also timeout has been reduced to 10s as 30s is a bit aggressive, maybe it makes sense to lower it even more?
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
Let's discuss if
setAppStartEnd
is still needed.