Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replayOnError capture on iOS #2306

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: replayOnError capture on iOS #2306

merged 3 commits into from
Sep 25, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Sep 24, 2024

📜 Description

replay ID reported by the cocoa SDK is null when session replay is disabled and is only available once a replay has been captured after an error.

💡 Motivation and Context

Fixes the app crash during iOS app startup when session replay is disabled while onError replay is enabled.
Closes #2295

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (48c3cf1) to head (703db33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
+ Coverage   88.03%   90.93%   +2.90%     
==========================================
  Files         247       73     -174     
  Lines        8585     2373    -6212     
==========================================
- Hits         7558     2158    -5400     
+ Misses       1027      215     -812     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaind vaind marked this pull request as ready for review September 24, 2024 21:00
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 495.22 ms 548.82 ms 53.60 ms
Size 6.49 MiB 7.56 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e8603bb 377.51 ms 444.77 ms 67.26 ms
754cdbe 325.08 ms 390.53 ms 65.45 ms
1d47eb7 282.26 ms 342.52 ms 60.26 ms
afa6e2a 349.73 ms 428.48 ms 78.75 ms
ef2f368 350.06 ms 429.44 ms 79.38 ms
48adddf 353.96 ms 431.10 ms 77.14 ms
77db8d4 493.88 ms 533.85 ms 39.98 ms
453e1bc 320.41 ms 372.73 ms 52.32 ms
a775d3f 359.58 ms 436.68 ms 77.10 ms
aed5947 295.70 ms 348.18 ms 52.48 ms

App size

Revision Plain With Sentry Diff
e8603bb 6.34 MiB 7.28 MiB 967.80 KiB
754cdbe 6.16 MiB 7.14 MiB 1003.78 KiB
1d47eb7 6.16 MiB 7.14 MiB 1010.29 KiB
afa6e2a 6.27 MiB 7.20 MiB 955.69 KiB
ef2f368 5.94 MiB 6.89 MiB 975.81 KiB
48adddf 6.27 MiB 7.20 MiB 959.09 KiB
77db8d4 6.49 MiB 7.55 MiB 1.06 MiB
453e1bc 5.94 MiB 6.95 MiB 1.01 MiB
a775d3f 6.27 MiB 7.20 MiB 957.75 KiB
aed5947 5.94 MiB 6.96 MiB 1.02 MiB

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.69 ms 1249.02 ms 17.33 ms
Size 8.38 MiB 9.74 MiB 1.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cdf7172 1264.43 ms 1291.39 ms 26.96 ms
d0312c9 1205.55 ms 1224.45 ms 18.90 ms
deaeece 1252.82 ms 1279.04 ms 26.22 ms
84bc635 1252.26 ms 1273.96 ms 21.70 ms
b44db8f 1255.29 ms 1258.90 ms 3.61 ms
ecb4003 1266.94 ms 1290.24 ms 23.31 ms
88e4bfd 1236.44 ms 1256.33 ms 19.90 ms
cfa25fc 1251.77 ms 1275.69 ms 23.92 ms
abcdba3 1257.31 ms 1283.49 ms 26.18 ms
43760f9 1216.07 ms 1238.51 ms 22.44 ms

App size

Revision Plain With Sentry Diff
cdf7172 8.16 MiB 9.16 MiB 1.01 MiB
d0312c9 8.32 MiB 9.39 MiB 1.06 MiB
deaeece 8.16 MiB 9.17 MiB 1.01 MiB
84bc635 8.33 MiB 9.40 MiB 1.07 MiB
b44db8f 8.29 MiB 9.37 MiB 1.08 MiB
ecb4003 8.09 MiB 9.07 MiB 1000.82 KiB
88e4bfd 8.33 MiB 9.64 MiB 1.31 MiB
cfa25fc 8.32 MiB 9.43 MiB 1.10 MiB
abcdba3 8.15 MiB 9.12 MiB 989.76 KiB
43760f9 8.29 MiB 9.36 MiB 1.07 MiB

@vaind vaind merged commit e112bbc into main Sep 25, 2024
48 checks passed
@vaind vaind deleted the fix/onerror-replay branch September 25, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Replay crashing iOS application
2 participants