-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send Less Client Reports When Rate Limited #2380
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2380 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 253 254 +1
Lines 9097 9113 +16
=======================================
+ Hits 7707 7721 +14
- Misses 1390 1392 +2 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1a93825 | 347.31 ms | 424.54 ms | 77.23 ms |
a510d1d | 295.63 ms | 344.65 ms | 49.03 ms |
a7acb24 | 301.00 ms | 357.38 ms | 56.38 ms |
6034b0a | 406.35 ms | 475.93 ms | 69.59 ms |
2d74010 | 400.42 ms | 466.50 ms | 66.08 ms |
4b5a4f6 | 394.19 ms | 471.81 ms | 77.62 ms |
bf8d36c | 505.00 ms | 563.18 ms | 58.18 ms |
e82709a | 361.18 ms | 423.50 ms | 62.32 ms |
c732386 | 316.84 ms | 390.62 ms | 73.78 ms |
24f71aa | 358.49 ms | 455.90 ms | 97.41 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1a93825 | 6.27 MiB | 7.20 MiB | 956.36 KiB |
a510d1d | 5.94 MiB | 6.96 MiB | 1.02 MiB |
a7acb24 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
6034b0a | 6.34 MiB | 7.29 MiB | 970.36 KiB |
2d74010 | 6.33 MiB | 7.26 MiB | 943.41 KiB |
4b5a4f6 | 6.34 MiB | 7.28 MiB | 962.57 KiB |
bf8d36c | 6.49 MiB | 7.56 MiB | 1.07 MiB |
e82709a | 6.34 MiB | 7.29 MiB | 970.37 KiB |
c732386 | 6.26 MiB | 7.20 MiB | 958.78 KiB |
24f71aa | 6.06 MiB | 7.03 MiB | 990.30 KiB |
Previous results on branch: enha/client-reports-rate-limiting
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5977911 | 447.83 ms | 485.13 ms | 37.30 ms |
c7f254c | 462.83 ms | 490.56 ms | 27.73 ms |
9a345d1 | 444.06 ms | 482.57 ms | 38.50 ms |
860c2c8 | 445.57 ms | 493.96 ms | 48.39 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5977911 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
c7f254c | 6.49 MiB | 7.57 MiB | 1.08 MiB |
9a345d1 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
860c2c8 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d4d0807 | 1246.94 ms | 1260.69 ms | 13.75 ms |
f9d18f3 | 1240.20 ms | 1242.78 ms | 2.57 ms |
04bd9e6 | 1230.78 ms | 1250.71 ms | 19.94 ms |
051e97a | 1245.94 ms | 1249.51 ms | 3.57 ms |
b8562d0 | 1249.92 ms | 1267.56 ms | 17.64 ms |
affcf07 | 1240.61 ms | 1266.49 ms | 25.88 ms |
2e8b1e1 | 1247.45 ms | 1263.67 ms | 16.22 ms |
0f067d3 | 1245.71 ms | 1269.59 ms | 23.88 ms |
f1314d5 | 1246.46 ms | 1270.92 ms | 24.46 ms |
e239c83 | 1248.40 ms | 1269.28 ms | 20.89 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d4d0807 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
f9d18f3 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
04bd9e6 | 8.33 MiB | 9.61 MiB | 1.27 MiB |
051e97a | 8.28 MiB | 9.34 MiB | 1.06 MiB |
b8562d0 | 8.33 MiB | 9.54 MiB | 1.22 MiB |
affcf07 | 8.38 MiB | 9.70 MiB | 1.33 MiB |
2e8b1e1 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
0f067d3 | 8.32 MiB | 9.52 MiB | 1.20 MiB |
f1314d5 | 8.10 MiB | 9.08 MiB | 1004.30 KiB |
e239c83 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
Previous results on branch: enha/client-reports-rate-limiting
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9a345d1 | 1249.06 ms | 1272.39 ms | 23.33 ms |
860c2c8 | 1260.31 ms | 1288.85 ms | 28.54 ms |
5977911 | 1234.78 ms | 1251.49 ms | 16.71 ms |
c7f254c | 1245.04 ms | 1274.59 ms | 29.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9a345d1 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
860c2c8 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
5977911 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
c7f254c | 8.38 MiB | 9.75 MiB | 1.37 MiB |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Send Less Client Reports When Rate Limited ([#2380](https://github.com/getsentry/sentry-dart/pull/2380)) If none of the above apply, you can opt out of this check by adding |
📜 Description
💡 Motivation and Context
Closes #2370
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled