Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows native method need default result #943

Merged
merged 6 commits into from
Jul 21, 2022

Conversation

wangbax
Copy link
Contributor

@wangbax wangbax commented Jul 12, 2022

📜 Description

When flutter is natively connected, the unimplemented logic needs to call back NotImplemented by default, otherwise it will be stuck in await.

💡 Motivation and Context

Pending line: https://github.com/getsentry/sentry-dart/blob/main/dart/lib/src/sentry_tracer.dart#L102
Link code: sentry_native_channel

💚 How did you test it?

  • Init set SentryFlutter.init.options.debug = true
  • Check log print

image

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

no op

#skip-changelog

@codecov-commenter
Copy link

Codecov Report

Merging #943 (ea15960) into main (287b3ad) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   89.81%   89.80%   -0.01%     
==========================================
  Files         104       95       -9     
  Lines        3211     3042     -169     
==========================================
- Hits         2884     2732     -152     
+ Misses        327      310      -17     
Impacted Files Coverage Δ
logging/lib/src/logging_integration.dart
dio/lib/src/sentry_dio_extension.dart
dio/lib/src/dio_event_processor.dart
logging/lib/src/extension.dart
dio/lib/src/breadcrumb_client_adapter.dart
dio/lib/src/sentry_dio_client_adapter.dart
dio/lib/src/sentry_transformer.dart
dio/lib/src/tracing_client_adapter.dart
dio/lib/src/failed_request_interceptor.dart

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287b3ad...ea15960. Read the comment docs.

@marandaneto
Copy link
Contributor

@wangbax please add a changelog entry :) it's a user facing fix.

@wangbax
Copy link
Contributor Author

wangbax commented Jul 21, 2022

@marandaneto has done. 😊

@marandaneto marandaneto merged commit 5a205e7 into getsentry:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants