Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Duplicated Android Breadcrumbs with no Mechanism #954

Merged
merged 8 commits into from
Jul 22, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jul 21, 2022

📜 Description

Closes #952

💚 How did you test it?

Added unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase denrase changed the title Fix: Duplicated Android Breadcrumbs Fix: Duplicated Android Breadcrumbs with no Mechanism Jul 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #954 (a1c89d3) into main (5a205e7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #954   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files         104      104           
  Lines        3212     3212           
=======================================
  Hits         2885     2885           
  Misses        327      327           
Impacted Files Coverage Δ
dart/lib/src/sentry_client.dart 92.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a205e7...a1c89d3. Read the comment docs.

@denrase
Copy link
Collaborator Author

denrase commented Jul 21, 2022

@marandaneto The "CI" issue was that we would run on "Android" as a platform, and we changed the behaviour to removing breadcrumbs if there are no mechanisms, which is also true if there are no exceptions. I have set a fixed platform (iOS) now for this particular unit test file.

@denrase denrase marked this pull request as ready for review July 21, 2022 12:11
@marandaneto marandaneto enabled auto-merge (squash) July 22, 2022 11:40
@marandaneto marandaneto merged commit 59ffb07 into main Jul 22, 2022
@marandaneto marandaneto deleted the fix/duplicated-android-crumbs branch July 22, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumbs are duplicated if there is no mechaism on Android
3 participants