Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeBreadcrumb was not adding the mutated breadcrumb #982

Merged
merged 5 commits into from
Aug 17, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Aug 16, 2022

📜 Description

beforeBreadcrumb was not adding the mutated breadcrumb

💡 Motivation and Context

Fix #980
Fix #977

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #982 (68fb0ce) into main (1998016) will decrease coverage by 1.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   91.14%   89.55%   -1.60%     
==========================================
  Files           9      106      +97     
  Lines         192     3322    +3130     
==========================================
+ Hits          175     2975    +2800     
- Misses         17      347     +330     
Impacted Files Coverage Δ
dart/lib/src/scope.dart 95.18% <100.00%> (ø)
...event_processor/deduplication_event_processor.dart 100.00% <0.00%> (ø)
dart/lib/src/isolate_error_integration.dart 91.66% <0.00%> (ø)
dart/lib/src/protocol/span_status.dart 96.49% <0.00%> (ø)
dart/lib/src/protocol/sentry_id.dart 84.61% <0.00%> (ø)
dart/lib/src/sentry_envelope.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/sentry_request.dart 98.03% <0.00%> (ø)
dart/lib/src/protocol/contexts.dart 90.15% <0.00%> (ø)
.../lib/src/http_client/sentry_http_client_error.dart 100.00% <0.00%> (ø)
...t/lib/src/sentry_attachment/sentry_attachment.dart 100.00% <0.00%> (ø)
... and 88 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -160,7 +160,7 @@
97C146E61CF9000F007C117D /* Project object */ = {
isa = PBXProject;
attributes = {
LastUpgradeCheck = 1330;
LastUpgradeCheck = 1300;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter 3.0.5 always changes that, so better to keep this change.

@marandaneto marandaneto mentioned this pull request Aug 16, 2022
9 tasks
Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto enabled auto-merge (squash) August 17, 2022 08:29
@marandaneto marandaneto merged commit ec2013e into main Aug 17, 2022
@marandaneto marandaneto deleted the fix/mutated-breadcrumb branch August 17, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beforeSend doesn't do anything NoSuchMethodError: method not found: 'headers' on null during tests
3 participants