Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve swift lints and compiler warnings #999

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Sep 7, 2022

#skip-changelog

closes #867

resolves the following compiler warnings:

/flutter/ios/Classes/SentryFlutterPluginApple.swift:470:35: warning: expression implicitly coerced from 'Dictionary<String, Any?>' to '[String : Any]'
          scope.setContext(value: dictionary, key: key)
                                  ^~~~~~~~~~
          scope.setContext(value: dictionary, key: key)
                                  ^~~~~~~~~~
                                             as [String : Any]
/flutter/ios/Classes/SentryFlutterPluginApple.swift:472:45: warning: expression implicitly coerced from 'String?' to 'Any'
          scope.setContext(value: ["value": string], key: key)
                                            ^~~~~~
          scope.setContext(value: ["value": string], key: key)
                                            ^~~~~~
                                                   ?? <#default value#>
          scope.setContext(value: ["value": string], key: key)
                                            ^~~~~~
                                                  !
          scope.setContext(value: ["value": string], key: key)
                                            ^~~~~~
                                                   as Any
/flutter/ios/Classes/SentryFlutterPluginApple.swift:512:31: warning: expression implicitly coerced from 'Dictionary<String, Any?>' to '[String : Any]'
          userInstance.data = extras
                              ^~~~~~
          userInstance.data = extras
                              ^~~~~~
                                     as [String : Any]
/flutter/ios/Classes/SentryFlutterPluginApple.swift:557:35: warning: expression implicitly coerced from 'Dictionary<String, Any?>' to '[String : Any]'
        breadcrumbInstance.data = data
                                  ^~~~
        breadcrumbInstance.data = data
                                  ^~~~
                                       as [String : Any]

and the lints from the CI
image

@marandaneto
Copy link
Contributor

Fixes #867

@marandaneto marandaneto merged commit ad4d975 into getsentry:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix or add lints for SwiftLint action
2 participants