Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SentryTower as InApp:true #21

Merged
merged 2 commits into from
Oct 21, 2024
Merged

add SentryTower as InApp:true #21

merged 2 commits into from
Oct 21, 2024

Conversation

bruno-garcia
Copy link
Member

Looks like we match against module so I guess this should work ( didn't test it 😬 )

Example event

Top frame was not showing (and link to GitHub doesn't render) because we mark it as InApp:false
image

Happened on issue:

{
"function": "OnReset",
"symbol": "SentryTower_OnReset_mFE6A942292A8D8C2865447CCB685B638E6CD295E",
"module": "SentryTower",
"package": "Assembly-CSharp, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null",
"filename": "SentryTower.cs",
"abs_path": "[/Users/bruno/git/sentry-defenses/game/Assets/Scripts/Sentry/SentryTower.cs](https://us.sentry.io/Users/bruno/git/sentry-defenses/game/Assets/Scripts/Sentry/SentryTower.cs)",
"lineno": 68,
"pre_context": [
"        _eventManager.OnGameResume -= OnResume;",
"    }",
"",
"    private void OnReset()",
"    {"
],
"context_line": "        if (gameObject == null)",
"post_context": [
"        {",
"            return;",
"        }",
"        ",
"        if (gameObject.CompareTag(\"Turd\"))"
],
"in_app": false,
"data": {
"symbolicator_status": "symbolicated"
},
"instruction_addr": "0x800000000105157c"
}

Copy link
Collaborator

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InAppInclude seems to work! 🎉
Great catch! Thanks for finding this!
Screenshot 2024-10-21 at 15 01 04

@bitsandfoxes bitsandfoxes merged commit 2e6845f into main Oct 21, 2024
2 checks passed
@bitsandfoxes bitsandfoxes deleted the sentry/in-app-tower branch October 21, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants