-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add explainer on continuous profiling and show how to enable it #10048
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 14 bytes ⬇️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some copyedits! Looks good overall!
I see that you set the deadline to tomorrow, but it sounds like this should maybe wait until the June 5 AM3 launch since you can't see continuous profiling data without being on the new plan. Is there a reason to publish this earlier?
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Hi @vivianyentran , thanks for the comments! This actually needs to wait even beyond the AM3 launch, since the frontend work to actually retrieve and view continuous profile data aren't done yet. I think it ships sometime next month. I'm going to set a new deadline and let's see how that one goes. |
Co-authored-by: vivianyentran <[email protected]>
@vivianyentran or maybe @kahest Could you point me towards the plan to migrate from platform-includes/getting-started-config/basic-config? I looked at #10290 but it looks like things were rewritten, not simply moved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left small clarifying suggestions, otherwise LGTM, thanks for adding this 🙏
@armcknight we refactored the structure of the getting started docs (the "landing page") so that it's more streamlined from a user PoV, and also easier to write for the developer. e.g. we got rid of dozens of nested platform includes that were partly empty and/or duplicated content, that's why the file structure changed. IMO it makes total sense to add continuous profiling to the experimental features page for now (as you did), we can promote it to the features page or even the getting started docs when we think most/everybody should use this |
Co-authored-by: Karl Heinz Struggl <[email protected]>
DESCRIBE YOUR PR
For getsentry/sentry-cocoa#3555
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: