Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(alerts): Add docs for dynamic alerts #11158

Merged
merged 7 commits into from
Nov 6, 2024
Merged

ref(alerts): Add docs for dynamic alerts #11158

merged 7 commits into from
Nov 6, 2024

Conversation

ceorourke
Copy link
Member

Add documentation for dynamic alerts. This is not urgent, probably won't be merged for a while as we'll be doing internal testing before releasing to EA.

Closes https://getsentry.atlassian.net/browse/ALRT-213

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:33pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:33pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:33pm

@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 301.94kB (1.69%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.89MB 301.95kB (3.52%) ⬆️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

@ceorourke ceorourke requested review from a team and lizokm August 27, 2024 21:53
vivianyentran
vivianyentran approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing these docs early!

docs/product/alerts/create-alerts/metric-alert-config.mdx Show resolved Hide resolved
docs/product/alerts/create-alerts/metric-alert-config.mdx Outdated Show resolved Hide resolved
docs/product/alerts/create-alerts/metric-alert-config.mdx Outdated Show resolved Hide resolved
lizokm
lizokm approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I left a few notes.

docs/product/alerts/create-alerts/metric-alert-config.mdx Outdated Show resolved Hide resolved
docs/product/alerts/alert-types.mdx Outdated Show resolved Hide resolved
docs/product/alerts/create-alerts/metric-alert-config.mdx Outdated Show resolved Hide resolved
docs/product/alerts/create-alerts/metric-alert-config.mdx Outdated Show resolved Hide resolved
docs/product/alerts/create-alerts/metric-alert-config.mdx Outdated Show resolved Hide resolved
@ram-senth ram-senth mentioned this pull request Sep 11, 2024
Open
@getsantry
Copy link
Contributor

getsantry bot commented Oct 5, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Oct 5, 2024
@ceorourke
Copy link
Member Author

beep boop commenting for the bot

@getsantry
Copy link
Contributor

getsantry bot commented Oct 29, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Oct 29, 2024
@ceorourke ceorourke added the wip label Oct 30, 2024
@ceorourke ceorourke force-pushed the ceorourke/anomaly-detection-docs branch from aab9d64 to 42de8f8 Compare November 5, 2024 17:14
@ceorourke ceorourke force-pushed the ceorourke/anomaly-detection-docs branch from f4afdd1 to b4120d0 Compare November 5, 2024 21:13
@ceorourke ceorourke merged commit 6842afe into master Nov 6, 2024
10 of 11 checks passed
@ceorourke ceorourke deleted the ceorourke/anomaly-detection-docs branch November 6, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizokm lizokm lizokm approved these changes

@vivianyentran vivianyentran vivianyentran approved these changes

Assignees
No one assigned
Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceorourke @vivianyentran @lizokm