Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(express): Add v7 docs #11519

Merged
merged 11 commits into from
Oct 10, 2024
Merged

docs(express): Add v7 docs #11519

merged 11 commits into from
Oct 10, 2024

Conversation

chargome
Copy link
Member

@chargome chargome commented Oct 8, 2024

includes a fix for #3881

fixes #11514

@chargome chargome self-assigned this Oct 8, 2024
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 8:25am
sentry-docs 🛑 Canceled (Inspect) Oct 10, 2024 8:25am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 8:25am

Copy link

codecov bot commented Oct 8, 2024

Bundle Report

Changes will increase total bundle size by 417 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.46MB 379 bytes (0.01%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.43MB 41 bytes (0.0%) ⬆️

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so sweet! Great work!

@chargome chargome requested a review from lizokm October 9, 2024 07:35
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few wording suggestions. Also got a bit of feedback from Rahul - he asked 1. If it would be possible to pull in the latest version number instead of just saying "latest" in the side nav. And 2. he said that there's a notification banner we use in the product that may look nicer than the yellow one we're using. (It already exists so we wouldn't need to ask the creative team to make anything for us).

docs/platforms/javascript/guides/express/index__v7.x.mdx Outdated Show resolved Hide resolved
app.listen(3000);
```

You can verify the Sentry integration by creating a route that will throw an error:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can verify the Sentry integration by creating a route that will throw an error:
You can verify the Sentry integration by creating the following route that will throw an error:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would rather leave this one as is, as basically any route will do the job!

@chargome
Copy link
Member Author

@lizokm thanks! I can include the remaining feedback in a separate PR 👍

@chargome chargome merged commit e56cb59 into master Oct 10, 2024
13 checks passed
@chargome chargome deleted the cg/express-versioned-docs branch October 10, 2024 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add versioned docs for express v7
3 participants