-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(express): Add v7 docs #11519
docs(express): Add v7 docs #11519
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 417 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so sweet! Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few wording suggestions. Also got a bit of feedback from Rahul - he asked 1. If it would be possible to pull in the latest version number instead of just saying "latest" in the side nav. And 2. he said that there's a notification banner we use in the product that may look nicer than the yellow one we're using. (It already exists so we wouldn't need to ask the creative team to make anything for us).
platform-includes/getting-started-node/javascript.express__v7.x.mdx
Outdated
Show resolved
Hide resolved
app.listen(3000); | ||
``` | ||
|
||
You can verify the Sentry integration by creating a route that will throw an error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can verify the Sentry integration by creating a route that will throw an error: | |
You can verify the Sentry integration by creating the following route that will throw an error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would rather leave this one as is, as basically any route will do the job!
platform-includes/getting-started-node/javascript.express__v7.x.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-node/javascript.express__v7.x.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-node/javascript.express__v7.x.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-node/javascript.express__v7.x.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-node/javascript.express__v7.x.mdx
Outdated
Show resolved
Hide resolved
platform-includes/getting-started-node/javascript.express__v7.x.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Liza Mock <[email protected]>
…x.mdx Co-authored-by: Liza Mock <[email protected]>
…x.mdx Co-authored-by: Liza Mock <[email protected]>
…x.mdx Co-authored-by: Liza Mock <[email protected]>
…x.mdx Co-authored-by: Liza Mock <[email protected]>
…x.mdx Co-authored-by: Liza Mock <[email protected]>
…x.mdx Co-authored-by: Liza Mock <[email protected]>
…x.mdx Co-authored-by: Liza Mock <[email protected]>
@lizokm thanks! I can include the remaining feedback in a separate PR 👍 |
includes a fix for #3881
fixes #11514