Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge and move Symfony Monolog docs #11534

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Conversation

stayallive
Copy link
Collaborator

DESCRIBE YOUR PR

Noticed the Monolog docs are now a bit duplicated and also right there in the getting started guide even though it's not strictly needed. Move everything to the monolog integration and leave a note about it in the installation guide (similar to how we handle this for Laravel).

Also a little tweak to the wording about log channels in Laravel, was a bit verbose.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 6:10pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 6:10pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:10pm

Copy link

codecov bot commented Oct 9, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.46MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.43MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cleptric cleptric enabled auto-merge (squash) October 9, 2024 17:40
@cleptric cleptric merged commit 97884d4 into master Oct 9, 2024
11 checks passed
@cleptric cleptric deleted the feature/fix-symfony-monolog branch October 9, 2024 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants