Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn repeated thread locality content into an include #11554

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

coolguyzone
Copy link
Collaborator

DESCRIBE YOUR PR

Turn a piece of content that's repeated 3 times into an include that can be managed in one place.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) Nov 7, 2024 10:46am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:46am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 10:46am

@coolguyzone
Copy link
Collaborator Author

coolguyzone commented Oct 16, 2024

Hey @jamescrosswell , in reference to your comment here about this content being repeated in 3x places: #11426

In this PR I went ahead and refactored them into a markdown Include so it can be managed in one place, please take a look if you're interested in seeing how this works.

@jamescrosswell
Copy link
Collaborator

please take a look if you're interested in seeing how this works.

Ah cool. Thanks @coolguyzone - much appreciated!

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I've made some wording tweaks and I think it would make more sense to add this note to the bottom of the section as opposed to having it be in the middle. As soon as we know for sure that it makes sense to add this note to Powershell and Unity docs, it's good to go!

@getsantry
Copy link
Contributor

getsantry bot commented Nov 7, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Bundle Report

Changes will increase total bundle size by 684 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.46MB 219 bytes (0.0%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.43MB 468 bytes (0.01%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants