-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn repeated thread locality content into an include #11554
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Hey @jamescrosswell , in reference to your comment here about this content being repeated in 3x places: #11426 In this PR I went ahead and refactored them into a markdown |
Ah cool. Thanks @coolguyzone - much appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! I've made some wording tweaks and I think it would make more sense to add this note to the bottom of the section as opposed to having it be in the middle. As soon as we know for sure that it makes sense to add this note to Powershell and Unity docs, it's good to go!
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Co-authored-by: Liza Mock <[email protected]>
Bundle ReportChanges will increase total bundle size by 684 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
DESCRIBE YOUR PR
Turn a piece of content that's repeated 3 times into an include that can be managed in one place.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES