Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags to issue-details page documentation #11749

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cmanallen
Copy link
Member

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:25pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:25pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Nov 6, 2024 8:25pm

Copy link

codecov bot commented Nov 6, 2024

Bundle Report

Changes will decrease total bundle size by 8 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.59MB 2 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

@@ -102,6 +102,21 @@ If you’ve enabled [Session Replay](/product/explore/session-replay/), you’ll

![Session Replay](./img/issue-replay.png)

## Feature Flags
If you’ve enabled a feature flag integration in your SDK you’ll have access to the feature flag table. If any flags were captured after the Sentry SDK's initialization and before the error event occured the table will contain rows of flag, evaluation-result pairs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you’ve enabled a feature flag integration in your SDK you’ll have access to the feature flag table. If any flags were captured after the Sentry SDK's initialization and before the error event occured the table will contain rows of flag, evaluation-result pairs.
If you’ve enabled a feature flag integration in your SDK you’ll have access to the feature flag table. If any flags were captured after the Sentry SDK's initialization and before the error event occurred, the table will contain rows of flag, evaluation-result pairs.


A timeline of suspect flags is also available if you've enabled at least one flag-audit-log integration.

!TODO! To enable a flag audit log click this button for the popup. Afterwards copy paste your web hook URL into the service provider. !TODO!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!TODO! To enable a flag audit log click this button for the popup. Afterwards copy paste your web hook URL into the service provider. !TODO!
!TODO! To enable a flag audit log click this button for the popup. Afterwards copy paste your web hook URL into the service provider. !TODO!

I'm guessing this should be a comment?

Copy link
Collaborator

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Pls see my comment about the TODO here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants