Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mermaid charts in dark mode #11754

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix mermaid charts in dark mode #11754

merged 2 commits into from
Nov 7, 2024

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Nov 7, 2024

closes #11733

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:49am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:49am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:49am

Copy link

codecov bot commented Nov 7, 2024

Bundle Report

Changes will increase total bundle size by 1.51kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.58MB 418 bytes (0.0%) ⬆️
sentry-docs-client-array-push 8.94MB 1.09kB (0.01%) ⬆️

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant say much about the code (because my JS/TS is very rusty) but I have tested it and it works!

@antonpirker antonpirker merged commit e0654b1 into master Nov 7, 2024
13 checks passed
@antonpirker antonpirker deleted the mermaid-dark-mode branch November 7, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling light/dark mode breaks mermaid diagrams
2 participants